From: maxime.ripard@free-electrons•com (Maxime Ripard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: sunxi: fix struct sys_timer removal
Date: Tue, 08 Jan 2013 20:13:00 +0100 [thread overview]
Message-ID: <50EC6FBC.2030100@free-electrons.com> (raw)
In-Reply-To: <1357666417-8803-1-git-send-email-swarren@wwwdotorg.org>
Hi Stephen,
On 08/01/2013 18:33, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia•com>
>
> Commit 6bb27d7 "ARM: delete struct sys_timer" removed struct sys_timer,
> but didn't update mach-sunxi/sunxi.c for this change, even though the
> sunxi timer implementation itself was updated. This caused a build break:
>
> arch/arm/mach-sunxi/sunxi.c:94:2: error: unknown field 'timer' specified in initializer
> arch/arm/mach-sunxi/sunxi.c:94:12: error: 'sunxi_timer' undeclared here (not in a function)
>
> Signed-off-by: Stephen Warren <swarren@nvidia•com>
> ---
> Ideally, this commit would be squashed into 6bb27d7 in arm-soc's
> timer-cleanup branch. However, that would change a few commit IDs, and
> I've already pulled that branch into the Tegra and bcm2835 trees. I can
> rebase those without issue if we co-ordinate so all the changes go into
> the same linux-next version.
>
> However, since sunxi isn't actually enabled in any defconfig until
> v3.8-rc2, perhaps it's OK to apply this change as a separate patch on
> top of timer-rework, and ignore the bisect issue?
I'm fine with having it as a follow-up patch.
Also, you can add my
Acked-by: Maxime Ripard <maxime.ripard@free-electrons•com>
Since I assume that Olof will apply this directly?
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-01-08 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 17:33 [PATCH] ARM: sunxi: fix struct sys_timer removal Stephen Warren
2013-01-08 19:13 ` Maxime Ripard [this message]
2013-01-08 21:13 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EC6FBC.2030100@free-electrons.com \
--to=maxime.ripard@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox