Subject: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels

From: [email-masked] (Santosh Shilimkar)
Date: Thu, 10 Jan 2013 16:18:39 +0530

On Thursday 10 January 2013 03:59 PM, Chen Gang wrote:
>
>    dma_lch_count is zero before 1st call of omap_system_dma_probe.
>    omap_dma_reserve_channels has value before 1st call of omap_system_dma_probe
>
>    when 1st call of omap_system_dma_probe
>      we need set dma_lch_count before use it for judging
>      or which will be failed for omap_dma_reserve_channels
>
>    additional info:
>      this patch is only for fixing bug, not touch the features.
>      so, not use d->lch_count instead of dma_lch_count for the statement:
>
>                          && (omap_dma_reserve_channels <= dma_lch_count))
>
Why not ? Infact thats the right fix as mentioned in the review.

>      at least, now, current fixing is equal to above.
>      in the future
>        maybe omap_dma_reserve_channels can be set by outside (such as from /proc)
>        dma_lch_count is a static global variable which has effect to all devices.
>        maybe the original author do not hope the newer is larger than the older
>
'omap_dma_reserve_channels' when used is suppose to be from command
line. Hence the proposed fix in the review is the right one.

Regards
santosh