From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels
Date: Thu, 10 Jan 2013 16:21:33 +0530 [thread overview]
Message-ID: <50EE9D35.6060300@ti.com> (raw)
In-Reply-To: <50EE9C87.6060407@ti.com>
On Thursday 10 January 2013 04:18 PM, Santosh Shilimkar wrote:
> On Thursday 10 January 2013 03:59 PM, Chen Gang wrote:
>>
>> dma_lch_count is zero before 1st call of omap_system_dma_probe.
>> omap_dma_reserve_channels has value before 1st call of
>> omap_system_dma_probe
>>
>> when 1st call of omap_system_dma_probe
>> we need set dma_lch_count before use it for judging
>> or which will be failed for omap_dma_reserve_channels
>>
>> additional info:
>> this patch is only for fixing bug, not touch the features.
>> so, not use d->lch_count instead of dma_lch_count for the statement:
>>
>> && (omap_dma_reserve_channels <= dma_lch_count))
>>
> Why not ? Infact thats the right fix as mentioned in the review.
>
>> at least, now, current fixing is equal to above.
>> in the future
>> maybe omap_dma_reserve_channels can be set by outside (such as
>> from /proc)
>> dma_lch_count is a static global variable which has effect to
>> all devices.
>> maybe the original author do not hope the newer is larger than
>> the older
>>
> 'omap_dma_reserve_channels' when used is suppose to be from command
> line. Hence the proposed fix in the review is the right one.
>
Another thing. please fix the subject line. It should be something like
below.
ARM: OMAP: Fix the use of uninitialized dma_lch_count
Regards
santosh
next prev parent reply other threads:[~2013-01-10 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 10:29 [PATCH] arch/arm/plat-omap: initializing dma_lch_count, before judging omap_dma_reserve_channels Chen Gang
2013-01-10 10:48 ` Santosh Shilimkar
2013-01-10 10:51 ` Santosh Shilimkar [this message]
2013-01-11 5:09 ` Chen Gang
2013-01-11 5:03 ` Chen Gang
2013-01-11 7:26 ` Santosh Shilimkar
2013-01-11 11:24 ` Chen Gang
2013-01-11 5:39 ` [PATCH] ARM: OMAP: Fix the use of uninitialized dma_lch_count Chen Gang
2013-01-11 11:38 ` Santosh Shilimkar
2013-02-01 22:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EE9D35.6060300@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox