From: florian@openwrt•org (Florian Fainelli)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] Fix phy_attach - forward dev_flags for phy_attach
Date: Thu, 10 Jan 2013 15:40:36 +0100 [thread overview]
Message-ID: <50EED2E4.80008@openwrt.org> (raw)
In-Reply-To: <1357819234-27752-3-git-send-email-konszert@marvell.com>
Le 01/10/13 13:00, Kosta Zertsekel a ?crit :
> Change-Id: Ie3191f95c36eada6d0c673460de5393641128182
> ---
> drivers/net/ethernet/marvell/pxa168_eth.c | 2 +-
> net/dsa/slave.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
I think that you should have actually two patches, one for pxa168_eth
and one for net/dsa/slave.c.
Also, please prefix your patches with what was usually used on these
files before: "pxa168_eth:" and "net: dsa:" respectively.
By the way, most, if not all of the phy_connect() users in
drivers/net/ethernet/ also do not ensure they pass the phy device flags,
so you might want to fix this globally and not just for Marvell driver.
Thanks.
--
Florian
next prev parent reply other threads:[~2013-01-10 14:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 12:00 Fix phy_init for Marvell network eth driver Kosta Zertsekel
2013-01-10 12:00 ` [PATCH 1/2] " Kosta Zertsekel
2013-01-10 13:22 ` Sergei Shtylyov
2013-01-10 12:00 ` [PATCH 2/2] Fix phy_attach - forward dev_flags for phy_attach Kosta Zertsekel
2013-01-10 14:40 ` Florian Fainelli [this message]
2013-01-10 15:57 ` Kosta Zertsekel
2013-01-10 17:12 ` Florian Fainelli
2013-01-10 12:17 ` Fix phy_init for Marvell network eth driver Jason Cooper
2013-01-10 12:24 ` Andrew Lunn
2013-01-10 12:27 ` Kosta Zertsekel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EED2E4.80008@openwrt.org \
--to=florian@openwrt$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox