public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: pgaikwad@nvidia•com (Prashant Gaikwad)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 0/9] Migrate Tegra to common clock framework
Date: Fri, 11 Jan 2013 13:42:08 +0530	[thread overview]
Message-ID: <50EFC958.2090900@nvidia.com> (raw)
In-Reply-To: <50EDAA39.3040609@wwwdotorg.org>

On Wednesday 09 January 2013 11:04 PM, Stephen Warren wrote:
> On 01/09/2013 03:59 AM, Prashant Gaikwad wrote:
>> On Wednesday 09 January 2013 02:31 AM, Stephen Warren wrote:
>>> On 01/08/2013 11:49 AM, Stephen Warren wrote:
>>>> On 01/08/2013 06:19 AM, Prashant Gaikwad wrote:
>>>>> On Tuesday 08 January 2013 05:40 AM, Stephen Warren wrote:
>>>>>> On 01/04/2013 10:22 AM, Stephen Warren wrote:
>>>>>>> On 01/04/2013 02:40 AM, Prashant Gaikwad wrote:
>>>>>>>> This patchset does following:
>>>>>>>> 1. Decompose single tegra clock structure into multiple clocks.
>>>>>>>> 2. Try to use standard clock types supported by common clock
>>>>>>>> framework.
>>>>>>>> 3. Use dynamic initialization.
>>>>>>>> 4. Move all clock code to drivers/clk/tegra from mach-tegra.
>>>>>>>> 5. Add device tree support for Tegra20 and Tegra30 clocks.
>>>>>>>> 6. Remove all legacy clock code from mach-tegra.
>>>>>>> I think there are bugs here. I applied all your clock patches on
>>>>>>> top of
>>>>>>> Tegra's for-next (see list below), and found that the following don't
>>>>>>> work on Springbank:
>>>>>>>
>>>>>>> * HDMI display
>>>>>>> * Audio playback
>>>>>>> * WiFi
>>>>>> (BTW, I stopped Cc'ing linux-kernel@, but added linux-tegra@
>>>>>> instead...)
>>>>>>
>>>>>> Prashant, some updated testing results based off the "dev/ccf" branch
>>>>>> you sent me on our internal git server:
>>>> ...
>>>>> I have updated the internal branch with all the above mentioned fixes.
>>> ...
>>>> The remaining item is the display issue on Tegra30, which I'll go look
>>>> at now.
>>> The USB3 clock, which isn't used by any drivers on Tegra30, and hence
>>> was disabled at boot, was set up incorrectly and ended up mapping to the
>>> disp1 clock, and hence turned off the display. The following fixes it:
>> Stephen, thanks for the fix!! I have included this and PLLE fix; updated
>> internal branch.
> Almost everything works great now.

Great!!

> However, I don't see any fix for the PLLE issue in the code; if there is
> one it certainly doesn't work. Applying my previous hack makes it work.

There is some difference between Tegra20 and Tegra30 PLLE implementation.
Fixed in latest patches sent.

> FYI, the branch I tested with is at
> git://nv-tegra.nvidia.com/user/swarren/linux-2.6 test-ccf-rework-2
>
> It's rebased onto the latest Tegra for-next.

      parent reply	other threads:[~2013-01-11  8:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04  9:40 [PATCH v3 0/9] Migrate Tegra to common clock framework Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 1/9] ARM: tegra: Add function to read chipid Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 2/9] clk: tegra: Add tegra specific clocks Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 3/9] arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 4/9] ARM: tegra: Define Tegra20 CAR binding Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 5/9] ARM: Tegra: Define Tegra30 " Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 6/9] clk: tegra: add clock support for tegra20 Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 7/9] clk: tegra: add clock support for tegra30 Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 8/9] arm: tegra: Migrate to new clock code Prashant Gaikwad
2013-01-04  9:40 ` [PATCH v3 9/9] arm: tegra: Remove legacy " Prashant Gaikwad
2013-01-04 11:20 ` [PATCH v3 0/9] Migrate Tegra to common clock framework Joseph Lo
2013-01-04 17:22 ` Stephen Warren
2013-01-08  0:10   ` Stephen Warren
2013-01-08 13:19     ` Prashant Gaikwad
2013-01-08 18:49       ` Stephen Warren
2013-01-08 21:01         ` Stephen Warren
2013-01-09 10:59           ` Prashant Gaikwad
2013-01-09 17:34             ` Stephen Warren
2013-01-09 20:44               ` Stephen Warren
2013-01-11  8:10                 ` Prashant Gaikwad
2013-01-11 15:59                   ` Marc Dietrich
2013-01-11 18:23                     ` Stephen Warren
2013-01-11 19:52                       ` Marc Dietrich
2013-01-11  8:12               ` Prashant Gaikwad [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EFC958.2090900@nvidia.com \
    --to=pgaikwad@nvidia$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox