From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/6] arm: mvebu: Add support for local interrupt
Date: Tue, 22 Jan 2013 10:09:03 +0100 [thread overview]
Message-ID: <50FE572F.4090402@free-electrons.com> (raw)
In-Reply-To: <20130121232637.GA3412@localhost>
On 01/22/2013 12:26 AM, Ezequiel Garcia wrote:
> Hi Thomas and Gregory,
>
> On Mon, Jan 21, 2013 at 11:07:10PM +0100, Gregory CLEMENT wrote:
>> On 01/21/2013 07:17 PM, Thomas Petazzoni wrote:
>>>> + irq_set_percpu_devid(virq);
>>>> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip,
>>>> + handle_percpu_devid_irq);
>>>> +
>>>> + } else {
>>>> + irq_set_chip_and_handler(virq, &armada_370_xp_irq_chip,
>>>> + handle_level_irq);
>>>> + }
>>>
>>> Braces useless since there is only one statement in the else.
>>>
>
> IMHO, this is an exception to the rule.
> Since the first block is more than one line,
> we usually put braces on the single line block too.
> (or at least that's what Documentation/CodingStyle says).
>
You're right!
I would have liked to say I have done it on purpose, but in fact these
braces are here only because during development I had had multiples lines
inside the else.
However, as you pointed it, I will keep it.
> Regards,
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-01-22 9:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 17:53 [PATCH 0/6] arm: mvebu: add support for local timer for Armada 370/XP Gregory CLEMENT
2013-01-21 17:53 ` [PATCH 1/6] arm: mvebu: Add support for local interrupt Gregory CLEMENT
2013-01-21 18:17 ` Thomas Petazzoni
2013-01-21 22:07 ` Gregory CLEMENT
2013-01-21 23:26 ` Ezequiel Garcia
2013-01-22 9:09 ` Gregory CLEMENT [this message]
2013-01-22 16:55 ` Thomas Petazzoni
2013-01-21 17:53 ` [PATCH 2/6] clocksource: time-armada-370-xp: add local timer support Gregory CLEMENT
2013-01-21 17:59 ` Russell King - ARM Linux
2013-01-21 18:04 ` Gregory CLEMENT
2013-01-23 13:11 ` Gregory CLEMENT
2013-01-21 17:53 ` [PATCH 3/6] arm: kconfig: don't select TWD with local timer for Armada 370/XP Gregory CLEMENT
2013-01-21 18:31 ` Arnd Bergmann
2013-01-21 19:29 ` Matt Sealey
2013-01-21 20:44 ` Arnd Bergmann
2013-01-22 17:12 ` Russell King - ARM Linux
2013-01-22 20:46 ` Rob Herring
2013-01-22 21:19 ` Arnd Bergmann
2013-01-21 22:37 ` Gregory CLEMENT
2013-01-22 15:57 ` Arnd Bergmann
2013-01-22 16:34 ` Gregory CLEMENT
2013-01-22 17:42 ` [PATCH] arm: kconfig: always select TWD with local timer for multiplatform Gregory CLEMENT
2013-01-22 17:18 ` [PATCH 3/6] arm: kconfig: don't select TWD with local timer for Armada 370/XP Russell King - ARM Linux
2013-01-22 17:42 ` Arnd Bergmann
2013-01-21 17:54 ` [PATCH 4/6] arm: mvebu: update defconfig with local timer support Gregory CLEMENT
2013-01-21 17:54 ` [PATCH 5/6] arm: mvebu: update DT to support local timers Gregory CLEMENT
2013-01-21 17:54 ` [PATCH 6/6] clocksource: update and move armada-370-xp-timer documentation to timer directory Gregory CLEMENT
2013-01-21 18:22 ` Arnd Bergmann
2013-01-21 22:05 ` Gregory CLEMENT
2013-01-21 22:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FE572F.4090402@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox