From: ludovic.desroches@atmel•com (ludovic.desroches)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] i2c: at91: add of_device_id entry for at91rm9200
Date: Thu, 24 Jan 2013 08:58:28 +0100 [thread overview]
Message-ID: <5100E9A4.9020804@atmel.com> (raw)
In-Reply-To: <20130124072714.GH8364@nekote.pengutronix.de>
Hi,
On 01/24/2013 08:27 AM, Wolfram Sang wrote:
> On Tue, Dec 18, 2012 at 07:02:32AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 22:42 Wed 05 Dec , Joachim Eastwood wrote:
>>> Signed-off-by: Joachim Eastwood <manabian@gmail•com>
>>> ---
>>> Hi,
>>>
>>> AT91RM9200 is gaining DT support now so let's add an id to the i2c driver.
>>>
>>> Tested on custom RM9200 board. Since the driver doesn't support pinctrl
>>> muxing yet I had to add pinctrl hogs for the i2c pins in my dts for it
>>> to work.
>>
>> IIRC the i2c IP have quite a lots of issue on rm9200 and until sam9g45
>>
>> it not recommended to use it instead use i2c-gpio
>
> Ludovic, you know the driver best. Does it make sense to add this?
I didn't add this when I did the rework because there was no DT tree
support for RM9200. The configuration for RM9200 IP is already in the
driver and used for non DT platform so I think it makes sense to add this.
But as Jean-Christophe said, it's recommended to use the i2c-gpio driver
since we know the first versions of the IP have several issues. However
if it fits user usage, it is not forbidden to use it.
Regards
Ludovic
>
>>
>> Best Regards,
>> J.
>>>
>>> regards
>>> Joachim Eastwood
>>>
>>> drivers/i2c/busses/i2c-at91.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
>>> index b4575ee..c504aa8 100644
>>> --- a/drivers/i2c/busses/i2c-at91.c
>>> +++ b/drivers/i2c/busses/i2c-at91.c
>>> @@ -584,6 +584,9 @@ static const struct platform_device_id at91_twi_devtypes[] = {
>>> #if defined(CONFIG_OF)
>>> static const struct of_device_id atmel_twi_dt_ids[] = {
>>> {
>>> + .compatible = "atmel,at91rm9200-i2c",
>>> + .data = &at91rm9200_config,
>>> + } , {
>>> .compatible = "atmel,at91sam9260-i2c",
>>> .data = &at91sam9260_config,
>>> } , {
>>> --
>>> 1.8.0
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2013-01-24 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 21:42 [PATCH] i2c: at91: add of_device_id entry for at91rm9200 Joachim Eastwood
2012-12-18 6:02 ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-24 7:27 ` Wolfram Sang
2013-01-24 7:58 ` ludovic.desroches [this message]
2013-01-24 8:43 ` Joachim Eastwood
2013-01-24 9:09 ` ludovic.desroches
2013-01-24 10:13 ` Wolfram Sang
2013-01-24 10:44 ` ludovic.desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5100E9A4.9020804@atmel.com \
--to=ludovic.desroches@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox