From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 2/2] ARM: davinci: Remoteproc platform device creation data/code
Date: Sat, 26 Jan 2013 18:42:49 +0400 [thread overview]
Message-ID: <5103EB69.5070101@mvista.com> (raw)
In-Reply-To: <1359168322-17733-3-git-send-email-rtivy@ti.com>
Hello.
On 26-01-2013 6:45, Robert Tivy wrote:
> Added a new remoteproc platform device for DA8XX. Contains CMA-based
> reservation of physical memory block. A new kernel command-line
> parameter has been added to allow boot-time specification of the
> physical memory block.
No signoff again.
> diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c
> index fb2f51b..a455e5c 100644
> --- a/arch/arm/mach-davinci/devices-da8xx.c
> +++ b/arch/arm/mach-davinci/devices-da8xx.c
[...]
> @@ -706,6 +706,96 @@ int __init da850_register_mmcsd1(struct davinci_mmc_config *config)
> }
> #endif
>
> +static struct resource da8xx_rproc_resources[] = {
> + { /* DSP boot address */
> + .start = DA8XX_SYSCFG0_BASE + DA8XX_HOST1CFG_REG,
> + .end = DA8XX_SYSCFG0_BASE + DA8XX_HOST1CFG_REG + 3,
> + .flags = IORESOURCE_MEM,
> + },
> + { /* DSP interrupt registers */
> + .start = DA8XX_SYSCFG0_BASE + DA8XX_CHIPSIG_REG,
> + .end = DA8XX_SYSCFG0_BASE + DA8XX_CHIPSIG_REG + 7,
> + .flags = IORESOURCE_MEM,
Does it really make sense to pass these as 2 resources -- they have the
same base address?
> +int __init da8xx_register_rproc(void)
> +{
> + int ret;
> +
> + ret = platform_device_register(&da8xx_dsp);
> + if (ret) {
> + pr_err("%s: platform_device_register: %d\n", __func__, ret);
Better message would be "can't register DSP device".
> +
Empty line hardly needed here.
> + return ret;
Not needed here, just move it outside the {} to replace 'return 0'.
> + }
> +
> + return 0;
> +};
> +
WBR, Sergei
next parent reply other threads:[~2013-01-26 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1359168322-17733-1-git-send-email-rtivy@ti.com>
[not found] ` <1359168322-17733-3-git-send-email-rtivy@ti.com>
2013-01-26 14:42 ` Sergei Shtylyov [this message]
2013-01-29 1:31 ` [PATCH v6 2/2] ARM: davinci: Remoteproc platform device creation data/code Tivy, Robert
[not found] ` <1359168322-17733-2-git-send-email-rtivy@ti.com>
2013-01-26 14:32 ` [PATCH v6 1/2] ARM: davinci: Remoteproc driver support for OMAP-L138 DSP Sergei Shtylyov
2013-01-30 2:28 ` Tivy, Robert
2013-01-26 15:21 ` Sergei Shtylyov
2013-01-28 23:56 ` Tivy, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5103EB69.5070101@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox