Subject: [RFC V2 PATCH 3/8] ARM: kirkwood: nsa310: cleanup includes and unneeded code

From: [email-masked] (Sergei Shtylyov)
Date: Sun, 27 Jan 2013 19:04:57 +0400

Hello.

On 27-01-2013 0:22, Jason Cooper wrote:

>>> Signed-off-by: Jason Cooper <[email-masked]>
>>> ---
>>>   arch/arm/mach-kirkwood/board-nsa310.c | 9 +--------
>>>   1 file changed, 1 insertion(+), 8 deletions(-)

>>> diff --git a/arch/arm/mach-kirkwood/board-nsa310.c b/arch/arm/mach-kirkwood/board-nsa310.c
>>> index 1bd328d..0b99533 100644
>>> --- a/arch/arm/mach-kirkwood/board-nsa310.c
>>> +++ b/arch/arm/mach-kirkwood/board-nsa310.c
>>> @@ -10,11 +10,8 @@
>>>
>>>   #include <linux/kernel.h>
>>>   #include <linux/init.h>
>>> -#include <linux/i2c.h>
>>> -
>>> -#include <asm/mach-types.h>
>>> -#include <asm/mach/arch.h>
>>>   #include <mach/kirkwood.h>
>>> +#include <linux/of.h>

>>     You also add an #include and don't mention it anywhere. Or is
>> that part of the cleanup?

> After removing the unneeded linux/i2c.h, linux/of.h was needed for
> of_machine_is_compatible().  i2c.h had included of.h.

    Would be worth mentioning it in the changelog.

> thanks for the review,

> Jason.

WBR, Sergei