From: peter.ujfalusi@ti•com (Peter Ujfalusi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/3] pwm: Add pwm_can_sleep() as exported API to users
Date: Tue, 29 Jan 2013 09:20:15 +0100 [thread overview]
Message-ID: <5107863F.10503@ti.com> (raw)
In-Reply-To: <1359381659-24454-2-git-send-email-florian.vaussard@epfl.ch>
On 01/28/2013 03:00 PM, Florian Vaussard wrote:
> Calls to some external PWM chips can sleep. To help users,
> add pwm_can_sleep() API.
>
> Cc: Thierry Reding <thierry.reding@avionic-design•de>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti•com>
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl•ch>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti•com>
> ---
> drivers/pwm/core.c | 12 ++++++++++++
> include/linux/pwm.h | 10 ++++++++++
> 2 files changed, 22 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index 4a13da4..41c0b0c 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -763,6 +763,18 @@ void devm_pwm_put(struct device *dev, struct pwm_device *pwm)
> }
> EXPORT_SYMBOL_GPL(devm_pwm_put);
>
> +/**
> + * pwm_can_sleep() - report whether PWM access will sleep
> + * @pwm: PWM device
> + *
> + * It returns true if accessing the PWM can sleep, false otherwise.
> + */
> +bool pwm_can_sleep(struct pwm_device *pwm)
> +{
> + return pwm->chip->can_sleep;
> +}
> +EXPORT_SYMBOL_GPL(pwm_can_sleep);
> +
> #ifdef CONFIG_DEBUG_FS
> static void pwm_dbg_show(struct pwm_chip *chip, struct seq_file *s)
> {
> diff --git a/include/linux/pwm.h b/include/linux/pwm.h
> index 70655a2..747c657 100644
> --- a/include/linux/pwm.h
> +++ b/include/linux/pwm.h
> @@ -146,6 +146,8 @@ struct pwm_ops {
> * @base: number of first PWM controlled by this chip
> * @npwm: number of PWMs controlled by this chip
> * @pwms: array of PWM devices allocated by the framework
> + * @can_sleep: flag must be set iff config()/enable()/disable() methods sleep,
> + * as they must while accessing PWM chips over I2C or SPI
> */
> struct pwm_chip {
> struct device *dev;
> @@ -159,6 +161,7 @@ struct pwm_chip {
> struct pwm_device * (*of_xlate)(struct pwm_chip *pc,
> const struct of_phandle_args *args);
> unsigned int of_pwm_n_cells;
> + bool can_sleep;
> };
>
> #if IS_ENABLED(CONFIG_PWM)
> @@ -182,6 +185,8 @@ struct pwm_device *devm_pwm_get(struct device *dev, const char *con_id);
> struct pwm_device *devm_of_pwm_get(struct device *dev, struct device_node *np,
> const char *con_id);
> void devm_pwm_put(struct device *dev, struct pwm_device *pwm);
> +
> +bool pwm_can_sleep(struct pwm_device *pwm);
> #else
> static inline int pwm_set_chip_data(struct pwm_device *pwm, void *data)
> {
> @@ -242,6 +247,11 @@ static inline struct pwm_device *devm_of_pwm_get(struct device *dev,
> static inline void devm_pwm_put(struct device *dev, struct pwm_device *pwm)
> {
> }
> +
> +static inline bool pwm_can_sleep(struct pwm_device *pwm)
> +{
> + return false;
> +}
> #endif
>
> struct pwm_lookup {
>
--
P?ter
next prev parent reply other threads:[~2013-01-29 8:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 14:00 [PATCH v3 0/3] leds-pwm: Defer PWM calls if PWM can sleep Florian Vaussard
2013-01-28 14:00 ` [PATCH v3 1/3] pwm: Add pwm_can_sleep() as exported API to users Florian Vaussard
2013-01-29 8:20 ` Peter Ujfalusi [this message]
2013-01-30 8:14 ` Thierry Reding
2013-01-28 14:00 ` [PATCH v3 2/3] pwm: Add can_sleep property to drivers Florian Vaussard
2013-01-30 8:15 ` Thierry Reding
2013-01-28 14:00 ` [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep Florian Vaussard
2013-01-29 8:20 ` Peter Ujfalusi
2013-01-30 8:17 ` Thierry Reding
2013-02-04 8:53 ` Florian Vaussard
2013-02-27 16:08 ` Florian Vaussard
2013-03-04 10:44 ` Florian Vaussard
2013-03-04 10:58 ` Thierry Reding
2013-03-05 15:39 ` Florian Vaussard
2013-03-12 10:06 ` Florian Vaussard
2013-03-15 17:08 ` Bryan Wu
2013-03-15 18:59 ` Thierry Reding
2013-03-15 20:09 ` Florian Vaussard
2013-03-15 21:02 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5107863F.10503@ti.com \
--to=peter.ujfalusi@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox