From: gang.chen@asianux•com (Chen Gang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM:common: setting saved_state to NULL after kfree
Date: Tue, 29 Jan 2013 19:34:09 +0800 [thread overview]
Message-ID: <5107B3B1.1030406@asianux.com> (raw)
In-Reply-To: <20130129111526.GQ23505@n2100.arm.linux.org.uk>
? 2013?01?29? 19:15, Russell King - ARM Linux ??:
> On Tue, Jan 29, 2013 at 07:11:43PM +0800, Chen Gang wrote:
>> > need set NULL before return, just like function sa1111_remove has done.
>> > and better to use sa1111_remove directly, instead of current implementation.
> NAK.
>
> 1. __sa1111_remove() will kfree sachip, so the value of sachip->saved_state
> at this point is meaningless.
yes, just like what you said. it is not a bug
(it seems not necessary to set saved_state to NULL in sa1111_remove, either).
I think, this patch can make the source code simpler and clearer.
so I still suggest to apply it (although it seems a minor patch).
> 2. I don't think you tried to build with your patch in place.
>
>
it is my fault, just like what you said, I did not try to build.
and I should try now.
thanks.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-01-29 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 11:11 [PATCH] ARM:common: setting saved_state to NULL after kfree Chen Gang
2013-01-29 11:15 ` Russell King - ARM Linux
2013-01-29 11:34 ` Chen Gang [this message]
2013-01-29 13:08 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5107B3B1.1030406@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox