From: rnayak@ti•com (Rajendra Nayak)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 07/10] ARM: OMAP5: clock data: Add OMAP54XX full clock tree and headers
Date: Thu, 31 Jan 2013 17:19:46 +0530 [thread overview]
Message-ID: <510A5A5A.9090708@ti.com> (raw)
In-Reply-To: <51095A65.9070102@ti.com>
On Wednesday 30 January 2013 11:07 PM, Jon Hunter wrote:
>
> On 01/18/2013 09:27 AM, Santosh Shilimkar wrote:
>> From: Rajendra Nayak <rnayak@ti•com>
>>
>> Add the clock tree related data for OMAP54xx platforms.
>
> [snip]
>
>> + CLK("omap_timer.1", "32k_ck", &sys_32k_ck, CK_54XX),
>> + CLK("omap_timer.2", "32k_ck", &sys_32k_ck, CK_54XX),
>> + CLK("omap_timer.3", "32k_ck", &sys_32k_ck, CK_54XX),
>> + CLK("omap_timer.4", "32k_ck", &sys_32k_ck, CK_54XX),
>> + CLK("omap_timer.5", "32k_ck", &sys_32k_ck, CK_54XX),
>> + CLK("omap_timer.6", "32k_ck", &sys_32k_ck, CK_54XX),
>> + CLK("omap_timer.7", "32k_ck", &sys_32k_ck, CK_54XX),
>> + CLK("omap_timer.8", "32k_ck", &sys_32k_ck, CK_54XX),
>> + CLK("omap_timer.9", "32k_ck", &sys_32k_ck, CK_54XX),
>> + CLK("omap_timer.10", "32k_ck", &sys_32k_ck, CK_54XX),
>> + CLK("omap_timer.11", "32k_ck", &sys_32k_ck, CK_54XX),
>
> I have been trying to get away from having so many aliases for the same
> clock for timers. Here we should replace all of the above and just have ...
>
> + CLK(NULL, "timer_32k_ck", &sys_32k_ck, CK_54XX),
>
> For more details see [1].
>
>> + CLK("omap_timer.1", "sys_ck", &sys_clkin, CK_54XX),
>> + CLK("omap_timer.2", "sys_ck", &sys_clkin, CK_54XX),
>> + CLK("omap_timer.3", "sys_ck", &sys_clkin, CK_54XX),
>> + CLK("omap_timer.4", "sys_ck", &sys_clkin, CK_54XX),
>> + CLK("omap_timer.9", "sys_ck", &sys_clkin, CK_54XX),
>> + CLK("omap_timer.10", "sys_ck", &sys_clkin, CK_54XX),
>> + CLK("omap_timer.11", "sys_ck", &sys_clkin, CK_54XX),
>> + CLK("omap_timer.5", "sys_ck", &dss_syc_gfclk_div, CK_54XX),
>> + CLK("omap_timer.6", "sys_ck", &dss_syc_gfclk_div, CK_54XX),
>> + CLK("omap_timer.7", "sys_ck", &dss_syc_gfclk_div, CK_54XX),
>> + CLK("omap_timer.8", "sys_ck", &dss_syc_gfclk_div, CK_54XX),
>> +};
>
> These aliases will not work with device-tree because the device-name is
> formatted <addr>.<device>. Hence, when configuring a the timer parent
> clock via the dmtimer driver it will fail. So it should be more like ...
>
> + CLK("4ae18000.timer", "timer_sys_ck", &sys_clkin, CK_54XX),
> + CLK("48032000.timer", "timer_sys_ck", &sys_clkin, CK_54XX),
> + CLK("48034000.timer", "timer_sys_ck", &sys_clkin, CK_54XX),
> + CLK("48036000.timer", "timer_sys_ck", &sys_clkin, CK_54XX),
> + CLK("40138000.timer", "timer_sys_ck", &sys_clkin, CK_54XX),
> + CLK("4013a000.timer", "timer_sys_ck", &sys_clkin, CK_54XX),
> + CLK("4013c000.timer", "timer_sys_ck", &sys_clkin, CK_54XX),
> + CLK("4013e000.timer", "timer_sys_ck", &dss_syc_gfclk_div,
> CK_54XX),
> + CLK("4803e000.timer", "timer_sys_ck", &dss_syc_gfclk_div, CK_54XX),
> + CLK("48086000.timer", "timer_sys_ck", &dss_syc_gfclk_div, CK_54XX),
> + CLK("48088000.timer", "timer_sys_ck", &dss_syc_gfclk_div, CK_54XX),
>
> For more details see [2].
Thanks Jon. I will update the autogen scripts to generate these
accordingly.
>
> If you would like to test the dmtimer driver on omap5, then you can grab
> my omap-test module [3], build it (see README), load it and then ...
>
> # echo 1 > /sys/kernel/debug/omap-test/timer/all
>
> This will perform some basic tests on all the dmtimers. I would do it
> myself, but there appears to be several issues getting this to boot on
> an ES1.0 (which is probably expected).
Right. This is ES2.0 data, so won't boot on an ES1.0 device.
regards,
Rajendra
>
> Cheers
> Jon
>
> [1] http://www.spinics.net/lists/linux-omap/msg71272.html
> [2] https://patchwork.kernel.org/patch/1204351/
> [3] https://github.com/jonhunter/omap-test
>
next prev parent reply other threads:[~2013-01-31 11:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 15:27 [PATCH 00/10] ARM: OMAP5: hwmod, clock and prm data files Santosh Shilimkar
2013-01-18 15:27 ` [PATCH 01/10] ARM: OMAP5: PRM: Add OMAP54XX register and bitfield files Santosh Shilimkar
2013-01-18 15:27 ` [PATCH 02/10] ARM: OMAP5: CM: " Santosh Shilimkar
2013-01-18 15:27 ` [PATCH 03/10] ARM: OMAP5: PRCM: Add OMAP54XX local MPU PRCM registers Santosh Shilimkar
2013-01-18 15:27 ` [PATCH 04/10] ARM: OMAP5: SCRM: Add OMAP54XX header file Santosh Shilimkar
2013-01-18 15:27 ` [PATCH 05/10] ARM: OMAP2+: clockdomain data: Add OMAP54XX data and update the header Santosh Shilimkar
2013-01-18 15:27 ` [PATCH 06/10] ARM: OMAP5: powerdomain " Santosh Shilimkar
2013-01-18 15:27 ` [PATCH 07/10] ARM: OMAP5: clock data: Add OMAP54XX full clock tree and headers Santosh Shilimkar
2013-01-18 17:19 ` Tony Lindgren
2013-01-21 8:14 ` Santosh Shilimkar
2013-01-21 18:08 ` Tony Lindgren
2013-01-21 14:27 ` Sebastien Guiriec
2013-01-21 14:31 ` Santosh Shilimkar
2013-01-21 21:34 ` Sebastien Guiriec
2013-01-30 17:37 ` Jon Hunter
2013-01-31 11:49 ` Rajendra Nayak [this message]
2013-01-18 15:27 ` [PATCH 08/10] ARM: OMAP5: hwmod data: Create initial OMAP5 SOC hwmod data Santosh Shilimkar
2013-01-18 17:15 ` Tony Lindgren
2013-01-21 8:11 ` Santosh Shilimkar
2013-01-21 14:25 ` Sebastien Guiriec
2013-01-21 15:06 ` Santosh Shilimkar
2013-01-21 18:01 ` Tony Lindgren
2013-01-22 12:55 ` Benoit Cousson
2013-01-22 18:32 ` Tony Lindgren
2013-01-29 13:57 ` Santosh Shilimkar
2013-01-29 17:24 ` Tony Lindgren
2013-01-30 9:10 ` Santosh Shilimkar
2013-01-22 13:14 ` Rajendra Nayak
2013-01-22 18:39 ` Tony Lindgren
2013-01-24 9:50 ` Rajendra Nayak
2013-01-25 16:55 ` Tony Lindgren
2013-01-18 15:27 ` [PATCH 09/10] ARM: OMAP5: voltagedomain data: Add OMAP5 voltage domain data Santosh Shilimkar
2013-01-18 15:27 ` [PATCH 10/10] ARM: OMAP5: Enable build and frameowrk initialisations Santosh Shilimkar
2013-02-01 9:13 ` [PATCH 00/10] ARM: OMAP5: hwmod, clock and prm data files Santosh Shilimkar
2013-04-03 20:13 ` Paul Walmsley
2013-04-04 10:36 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510A5A5A.9090708@ti.com \
--to=rnayak@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox