From: amit.virdi@st•com (Amit Virdi)
To: linux-arm-kernel@lists•infradead.org
Subject: ARM/Kernel: Problems with multiple VIC registration
Date: Wed, 13 Feb 2013 14:48:50 +0530 [thread overview]
Message-ID: <511B5A7A.1050201@st.com> (raw)
In-Reply-To: <CACRpkdZ4y8o6q1djRpg_VAxn-YY1AHG2BKR1aoAOfo0Ru2Vkwg@mail.gmail.com>
On 2/12/2013 6:41 PM, Linus Walleij wrote:
> On Tue, Feb 12, 2013 at 1:38 PM, Amit Virdi<amit.virdi@st•com> wrote:
>> On 2/6/2013 2:45 PM, Linus Walleij wrote:
>
>>> There are several things you can do wrong. For example a common mistake
>>> is to offset the IRQs on a new platform from zero. So that the first
>>> parameter to vic_init() is zero. This is not legal because Linux IRQ 0
>>> is NO_IRQ and shall not be used. If this is your problems, IRQs shall
>>> offset from something like 64 so you can even use SPARSE_IRQ.
>>
>> Yes, I was using 0 as the first offset in IRQs and my IRQs were defined from
>> 0 to n. I changed it to 1 to n+1 and I'm now not using 0. Every problem
>> seems to have resolved now.
>
> 1 and n+1 is only going to work as long as you're defining
> NR_IRQS in the platform or in the .nr_irqs member of
> the MACHINE record.
>
> If you use device tree or SPARSE_IRQ (which, by the way,
> you should turn on right now) you will run into trouble.
>
> Bump it to 64+n.
>
> Else you will just have to fix all this when you get to
> submitting board support upstream.
>
Okay, thanks for your support!!
Regards
Amit Virdi
prev parent reply other threads:[~2013-02-13 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 9:48 ARM/Kernel: Problems with multiple VIC registration Amit Virdi
2013-02-05 14:12 ` Rob Herring
2013-02-06 4:23 ` Amit Virdi
2013-02-05 16:27 ` Linus Walleij
2013-02-06 3:52 ` Amit Virdi
2013-02-06 9:15 ` Linus Walleij
2013-02-12 12:38 ` Amit Virdi
2013-02-12 13:11 ` Linus Walleij
2013-02-13 9:18 ` Amit Virdi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511B5A7A.1050201@st.com \
--to=amit.virdi@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox