From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 08/10] ARM: dt: Add references to tegra_car clocks
Date: Wed, 13 Feb 2013 09:48:03 -0700 [thread overview]
Message-ID: <511BC3C3.6070402@wwwdotorg.org> (raw)
In-Reply-To: <20130213113807.GE3073@tbergstrom-lnx.Nvidia.com>
On 02/13/2013 04:38 AM, Peter De Schrijver wrote:
> On Tue, Feb 12, 2013 at 06:24:05PM +0100, Stephen Warren wrote:
>> On 02/11/2013 04:04 AM, Peter De Schrijver wrote:
>>> Add references to tegra_car clocks for the basic device nodes.
>>
>> In this patch, you also need to remove the "clock-frequency" properties
>> from tegra114-*.dts board files.
>
> That would probably break bisectability no?
Oh right, I read the patch order backwards. You can fix this by moving
this patch to the end of the series.
> I think this needs to be done in a separate patch.
To avoid bisect issues, the clock-frequency property should be removed
in the same patch that adds the clocks property, or after it.
> Also, the UARTD enabling in init_table[] can then be removed.
You still need to initialize all the UART clocks in init_table[]. This
is required to make sure the clocks have the correct parent. Without
this explicit initialization, on Tegra30 at least, it was found that
UART C didn't work correctly for Bluetooth since the default parent was
something that wasn't generating the expected frequency.
Before removing the clock-frequency property, you also need to make sure
that init_table[] forces the UART clock on, otherwise since nothing will
clk_get()/enable() the UART clock, clk_disable_unused() will disable it.
After removing clock-frequency property, of_serial.c will
clk_get()/enable() the UART clock based on the clocks property, and
hence init_table[] doesn't need to force the UART clock on.
next prev parent reply other threads:[~2013-02-13 16:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 11:04 [PATCH v6 00/10] Tegra114 clockframework Peter De Schrijver
2013-02-11 11:04 ` [PATCH v6 01/10] clk: tegra: Refactor PLL programming code Peter De Schrijver
2013-02-11 11:04 ` [PATCH v6 02/10] clk: tegra: Add TEGRA_PLL_BYPASS flag Peter De Schrijver
2013-02-11 11:04 ` [PATCH v6 03/10] clk: tegra: Add PLL post divider table Peter De Schrijver
2013-02-11 11:04 ` [PATCH v6 04/10] clk: tegra: Add new fields and PLL types for Tegra114 Peter De Schrijver
2013-02-11 11:04 ` [PATCH v6 05/10] clk: tegra: Add flags to tegra_clk_periph() Peter De Schrijver
2013-02-11 11:04 ` [PATCH v6 06/10] clk: tegra: Workaround for Tegra114 MSENC problem Peter De Schrijver
2013-02-11 11:04 ` [PATCH v6 07/10] ARM: tegra: Define Tegra114 CAR binding Peter De Schrijver
2013-02-11 11:04 ` [PATCH v6 08/10] ARM: dt: Add references to tegra_car clocks Peter De Schrijver
2013-02-12 17:24 ` Stephen Warren
2013-02-13 11:38 ` Peter De Schrijver
2013-02-13 16:48 ` Stephen Warren [this message]
2013-02-14 10:01 ` Peter De Schrijver
2013-02-14 17:30 ` Stephen Warren
2013-02-15 12:22 ` Peter De Schrijver
2013-02-11 11:04 ` [PATCH v6 09/10] clk: tegra: Implement clocks for Tegra114 Peter De Schrijver
2013-02-15 5:39 ` Hiroshi Doyu
2013-02-15 6:18 ` Hiroshi Doyu
2013-02-15 9:13 ` Peter De Schrijver
2013-03-06 23:51 ` Andrew Chew
2013-03-11 9:25 ` Peter De Schrijver
2013-02-11 11:05 ` [PATCH v6 10/10] clk: tegra: devicetree match for nvidia, tegra114-car Peter De Schrijver
[not found] <1360330602-30472-1-git-send-email-pdeschrijver@nvidia.com>
2013-02-08 13:36 ` [PATCH v6 08/10] ARM: dt: Add references to tegra_car clocks Peter De Schrijver
2013-02-08 14:03 ` Felipe Balbi
2013-02-08 17:16 ` Stephen Warren
2013-02-11 10:03 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511BC3C3.6070402@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox