From: nsekhar@ti•com (Sekhar Nori)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v7 2/2] ARM: davinci: Remoteproc platform device creation data/code
Date: Fri, 15 Feb 2013 13:48:31 +0530 [thread overview]
Message-ID: <511DEF57.2070208@ti.com> (raw)
In-Reply-To: <78c80762cae70455b503d78702c3777c3a6d9321.1359684780.git.rtivy@ti.com>
Hi Rob,
On 2/1/2013 7:54 AM, Robert Tivy wrote:
> Added a new remoteproc platform device for DA8XX. Contains CMA-based
> reservation of physical memory block. A new kernel command-line
> parameter has been added to allow boot-time specification of the
> physical memory block.
>
> Signed-off-by: Robert Tivy <rtivy@ti•com>
This looks good to me. Except one minor nit below:
> +static struct platform_device da8xx_dsp = {
> + .name = "davinci-rproc",
> + .id = 0,
No need to zero initialize here.
> + .dev = {
> + .coherent_dma_mask = DMA_BIT_MASK(32),
> + },
> + .num_resources = ARRAY_SIZE(da8xx_rproc_resources),
> + .resource = da8xx_rproc_resources,
> +};
You can fix that and add my:
Acked-by: Sekhar Nori <nsekhar@ti•com>
in case this goes from outside of DaVinci tree.
Thanks,
Sekhar
prev parent reply other threads:[~2013-02-15 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1359684780.git.rtivy@ti.com>
[not found] ` <d9e1adbe6b12aab495f0292c4553c5c8f61c70b5.1359684780.git.rtivy@ti.com>
2013-02-15 8:07 ` [PATCH v7 1/2] ARM: davinci: Remoteproc driver support for OMAP-L138 DSP Ohad Ben-Cohen
2013-02-18 23:02 ` Tivy, Robert
2013-02-19 8:17 ` Ohad Ben-Cohen
2013-02-15 8:15 ` [PATCH v7 0/2] ARM: davinci: remoteproc support Sekhar Nori
[not found] ` <78c80762cae70455b503d78702c3777c3a6d9321.1359684780.git.rtivy@ti.com>
2013-02-15 8:18 ` Sekhar Nori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511DEF57.2070208@ti.com \
--to=nsekhar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox