From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 02/11] gpio: pxa: clean code with same variable name
Date: Wed, 20 Feb 2013 10:13:54 +0200 [thread overview]
Message-ID: <512485C2.50504@compulab.co.il> (raw)
In-Reply-To: <1361290948-16669-3-git-send-email-haojian.zhuang@linaro.org>
On 02/19/13 18:22, Haojian Zhuang wrote:
> Clean code to avoid similar variable. Now use gc for gpio_chip,
> and use c/chip for pxa_gpio_chip. It's used to avoid confusion.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro•org>
Tested-by: Igor Grinberg <grinberg@compulab•co.il>
Minor issue below for your consideration.
> ---
> drivers/gpio/gpio-pxa.c | 102 +++++++++++++++++++++++------------------------
> 1 file changed, 50 insertions(+), 52 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
> index a4c6687..e611bed 100644
> --- a/drivers/gpio/gpio-pxa.c
> +++ b/drivers/gpio/gpio-pxa.c
[...]
> @@ -147,7 +147,7 @@ static inline int __gpio_is_occupied(unsigned gpio)
> int ret, af = 0, dir = 0;
>
> pxachip = gpio_to_pxachip(gpio);
> - base = gpio_chip_base(&pxachip->chip);
> + base = gpio_chip_base(&pxachip->gc);
I don't mind leaving this as it is, but according
to your commit message, the above should be:
c/chip = gpio_to_pxachip(gpio);
base = gpio_chip_base(&c/chip->gc);
For your consideration.
> gpdr = readl_relaxed(base + GPDR_OFFSET);
>
> switch (gpio_type) {
[...]
--
Regards,
Igor.
next prev parent reply other threads:[~2013-02-20 8:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 16:22 [PATCH v4 00/11] enhance DT support on gpio pxa Haojian Zhuang
2013-02-19 16:22 ` [PATCH v4 01/11] gpio: pxa: identify ed mask reg with platform data Haojian Zhuang
2013-02-19 16:22 ` [PATCH v4 02/11] gpio: pxa: clean code with same variable name Haojian Zhuang
2013-02-20 8:13 ` Igor Grinberg [this message]
[not found] ` <CAD6h2NQy4LAoUkS=b301huXRJ_kyPcMxoC8E99dud7d-842=cw@mail.gmail.com>
2013-03-01 0:37 ` Linus Walleij
2013-02-19 16:22 ` [PATCH v4 03/11] gpio: pxa: use platform data for gpio inverted Haojian Zhuang
2013-02-19 16:22 ` [PATCH v4 04/11] gpio: pxa: remove gpio_type Haojian Zhuang
2013-02-20 8:18 ` Igor Grinberg
2013-03-01 0:33 ` Linus Walleij
2013-02-19 16:22 ` [PATCH v4 05/11] gpio: pxa: define nr gpios in platform data Haojian Zhuang
2013-02-20 14:02 ` Igor Grinberg
2013-02-19 16:22 ` [PATCH v4 06/11] gpio: pxa: add irq base " Haojian Zhuang
2013-02-20 14:08 ` Igor Grinberg
2013-02-19 16:22 ` [PATCH v4 07/11] document: devicetree: add properties in mrvl gpio Haojian Zhuang
2013-02-19 16:22 ` [PATCH v4 08/11] gpio: pxa: remove arch related macro Haojian Zhuang
2013-02-20 14:13 ` Igor Grinberg
2013-02-19 16:22 ` [PATCH v4 09/11] gpio: pxa: move gpio properties into child node Haojian Zhuang
2013-02-20 14:17 ` Igor Grinberg
2013-02-19 16:22 ` [PATCH v4 10/11] gpio: pxa: bind to pinctrl by request Haojian Zhuang
2013-02-20 14:26 ` Igor Grinberg
2013-02-19 16:22 ` [PATCH v4 11/11] ARM: dts: support pinmux in pxa910 Haojian Zhuang
2013-02-20 14:31 ` [PATCH v4 00/11] enhance DT support on gpio pxa Igor Grinberg
[not found] ` <CAD6h2NTe5K=6fKkm=n=ZawjhoR+_sOe5McX2soT7_Af22wKvDg@mail.gmail.com>
2013-02-22 17:30 ` Linus Walleij
2013-02-25 3:45 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512485C2.50504@compulab.co.il \
--to=grinberg@compulab$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox