From: csd@broadcom•com (Christian Daudt)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: bcm281xx: Add L2 cache enable code
Date: Wed, 6 Mar 2013 07:05:16 -0800 [thread overview]
Message-ID: <51375B2C.2000005@broadcom.com> (raw)
In-Reply-To: <201303061128.57127.arnd@arndb.de>
On 13-03-06 03:28 AM, Arnd Bergmann wrote:
>>>> It was originally in init_machine section but I was told that that was
>>>> too late and init_irq would be better, and I saw that highbank also has
>>>> it in init_irq. I agree that it is unrelated to irq - is there a better
>>>> place to put this in ?
>>> IMHO the later the better. Do you know what issues were caused by having it
>>> in init_machine?
>> This is some feedback I got a while back:
>> "From kernel 3.4 on-wards i think ( if i remember correctly) cache sync
>> might be called before your board_init function and you might have to do
>> this in init_irq. "
>>
>> I just looked through where l2x0_of_init is currently called and here's
>> the list:
>> early_initcall (exynos4, omap2, sirf, ux500)
>> init_irq (highbank, imx6q)
>> init_machine (socfpga, v2m_dt_init)
>>
>> so seems to be everywhere :) So I can move it back to init_machineif
>> that's where itshould be.
> Hmm, let's try to solve this another time, I don't think there is an easy
> answer. Maybe we really need a common entry point for the cache
> controller setup, or move it completely out of platform specific code
> for the case where it can be probed from DT.
>
> Thanks for doing the research!
>
So for the time being should it stay in init_irq or init_machine ?
Thanks,
csd
next prev parent reply other threads:[~2013-03-06 15:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 2:47 [PATCH] ARM: bcm281xx: Add L2 cache enable code Christian Daudt
2013-03-05 9:01 ` Arnd Bergmann
2013-03-05 22:54 ` Christian Daudt
2013-03-06 6:31 ` Arnd Bergmann
[not found] ` <5136F816.2070909@broadcom.com>
2013-03-06 11:28 ` Arnd Bergmann
2013-03-06 15:05 ` Christian Daudt [this message]
2013-04-10 17:33 ` [GIT PULL] ARM: bcm281xx firmware tags Christian Daudt
2013-04-11 6:52 ` Olof Johansson
2013-04-11 8:52 ` Olof Johansson
2013-03-05 18:20 ` [PATCH] ARM: bcm281xx: Add L2 cache enable code Stephen Warren
2013-03-05 22:56 ` Christian Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51375B2C.2000005@broadcom.com \
--to=csd@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox