From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/6] pinctrl: gpio: vt8500: Add pincontrol driver for arch-vt8500
Date: Wed, 13 Mar 2013 12:26:07 -0600 [thread overview]
Message-ID: <5140C4BF.3010708@wwwdotorg.org> (raw)
In-Reply-To: <CACRpkdZ14k_o-aO248NZJ6-jqxJf8AYhsZHLN_wPToyU1NsM6w@mail.gmail.com>
On 03/13/2013 10:11 AM, Linus Walleij wrote:
> On Sat, Mar 9, 2013 at 6:39 AM, Tony Prisk <linux@prisktech•co.nz> wrote:
>
>> This patch adds support for the GPIO/pinmux controller found on the VIA
>> VT8500 and Wondermedia WM8xxx-series SoCs.
> (...)
>> +static int wmt_pctl_dt_node_to_map(struct pinctrl_dev *pctldev,
>> + for (i = 0; i < num_pins; i++) {
>> + pin = prop_u32(pins, i);
>
> So I don't get this. What is wrong with of_property_read_u32()?
>
> I think there is something very strange about this parsing code
> if you can't use the common accessors to get the stuff you want,
> if you really need to inspect properties like that static inline does,
> then it should be explained and the function should *not* be in
> this driver but a helper in <linux/of_*> somewhere.
There is no of_property_read_u32_index(), which would read the nth u32
in a list of them. You're right there probably should be. My fault for
not creating one when I first wrote that code in the Tegra driver:-(
next prev parent reply other threads:[~2013-03-13 18:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 5:39 [PATCH 0/6] arm: vt8500: Add support for pinctrl/gpio module Tony Prisk
2013-03-09 5:39 ` [PATCH 1/6] arm: vt8500: Increase available GPIOs on arch-vt8500 Tony Prisk
2013-03-11 16:38 ` Russell King - ARM Linux
2013-03-12 4:04 ` Tony Prisk
2013-03-09 5:39 ` [PATCH 2/6] pinctrl: gpio: vt8500: Add pincontrol driver for arch-vt8500 Tony Prisk
2013-03-11 16:44 ` Stephen Warren
2013-03-12 4:21 ` [Bulk] " Tony Prisk
2013-03-13 14:29 ` Linus Walleij
2013-03-13 19:08 ` Tony Prisk
2013-03-13 19:13 ` Linus Walleij
2013-03-14 5:59 ` Tony Prisk
2013-03-27 8:40 ` Linus Walleij
2013-03-13 16:11 ` Linus Walleij
2013-03-13 18:26 ` Stephen Warren [this message]
2013-03-13 18:52 ` Linus Walleij
2013-03-13 18:59 ` Tony Prisk
2013-03-13 19:00 ` Tony Prisk
2013-03-09 5:39 ` [PATCH 3/6] arm: dts: vt8500: Update Wondermedia SoC dtsi files for pinctrl driver Tony Prisk
2013-03-11 16:46 ` Stephen Warren
2013-03-12 4:10 ` Tony Prisk
2013-03-09 5:39 ` [PATCH 4/6] arm: vt8500: Remove gpio devicetree nodes Tony Prisk
2013-03-13 16:14 ` Linus Walleij
2013-03-13 16:26 ` Arnd Bergmann
2013-03-09 5:39 ` [PATCH 5/6] gpio: vt8500: Remove arch-vt8500 gpio driver Tony Prisk
2013-03-09 5:39 ` [PATCH 6/6] arm: vt8500: Remove pinmux configuration from mach-vt8500/vt8500.c Tony Prisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140C4BF.3010708@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox