From: r.sricharan@ti•com (Sricharan R)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V6] ARM: LPAE: Fix mapping in alloc_init_section for unaligned addresses
Date: Sun, 17 Mar 2013 10:30:25 +0530 [thread overview]
Message-ID: <51454DE9.2070202@ti.com> (raw)
In-Reply-To: <CANOGCgNDRb5OT9_D2Kny1_VrKWUVr9B5hjnmJvHpvve7mjidOg@mail.gmail.com>
Hi Christoffer,
On Friday 15 March 2013 11:38 PM, Christoffer Dall wrote:
> On Fri, Mar 15, 2013 at 10:36 AM, Russell King - ARM Linux
> <linux@arm•linux.org.uk> wrote:
>> On Thu, Mar 14, 2013 at 09:28:51AM +0530, Sricharan R wrote:
>>> On Thursday 21 February 2013 05:56 PM, R Sricharan wrote:
>>>> Hi,
>>>> On Monday 11 February 2013 07:22 PM, R Sricharan wrote:
>>>>> Hi Russell,
>>>>>
>>>>> On Monday 11 February 2013 06:42 PM, Catalin Marinas wrote:
>>>>>> On Mon, Feb 11, 2013 at 09:13:29AM +0000, R Sricharan wrote:
>>>>>>> +static void __init alloc_init_pmd(pud_t *pud, unsigned long addr,
>>>>>>> + unsigned long end, phys_addr_t phys,
>>>>>>> + const struct mem_type *type)
>>>>>>> +{
>>>>>>> + pmd_t *pmd = pmd_offset(pud, addr);
>>>>>>> + unsigned long next;
>>>>>>> +
>>>>>>> + do {
>>>>>>> /*
>>>>>>> - * No need to loop; pte's aren't interested in the
>>>>>>> - * individual L1 entries.
>>>>>>> + * With LPAE, we must loop over to map
>>>>>>> + * all the pmds for the given range.
>>>>>>> */
>>>>>>> - alloc_init_pte(pmd, addr, end, __phys_to_pfn(phys), type);
>>>>>>> - }
>>>>>>> + next = pmd_addr_end(addr, end);
>>>>>>> +
>>>>>>> + /*
>>>>>>> + * Try a section mapping - end, addr and phys must all be
>>>>>>> + * aligned to a section boundary.posted
>>>>>>> + */
>>>>>>
>>>>>> Should this read "next, addr and phys" instead of "end..."?
>>>>>>
>>>>>> Otherwise:
>>>>>>
>>>>>> Reviewed-by: Catalin Marinas <catalin.marinas@arm•com>
>>>>>>
>>>>> Can I put this in to patch system ?
>>>>
>>>> Ping..
>>>>
>>>> Regards,
>>>> Sricharan
>>> Ping again..
>>
>> Do we have a winner out of all the patches which have been posted yet?
>
> I was fine with the latest version if my comments were addressed, but
> I don't remember seeing this version posted.
>
> Sricharan, can you please post a new complete patch that we can ack,
> and please remember cc'ing me directly so I don't miss it.
I posted a version after addressing your comments and Catalin
acked that as well. I will repost again now.
Regards,
Sricharan
next prev parent reply other threads:[~2013-03-17 5:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 9:13 [PATCH V6] ARM: LPAE: Fix mapping in alloc_init_section for unaligned addresses R Sricharan
2013-02-11 13:12 ` Catalin Marinas
2013-02-11 13:23 ` R Sricharan
2013-02-11 13:52 ` R Sricharan
2013-02-21 12:26 ` R Sricharan
2013-03-14 3:58 ` Sricharan R
2013-03-15 17:36 ` Russell King - ARM Linux
2013-03-15 18:08 ` Christoffer Dall
2013-03-17 5:00 ` Sricharan R [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-17 5:05 Sricharan R
2013-03-17 19:52 ` Christoffer Dall
2013-03-18 5:50 ` Sricharan R
2013-03-18 10:45 ` Russell King - ARM Linux
2013-03-18 10:54 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51454DE9.2070202@ti.com \
--to=r.sricharan@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox