From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv3 08/10] clocksource: time-armada-370-xp: Fix sparse warning
Date: Wed, 20 Mar 2013 18:06:49 +0100 [thread overview]
Message-ID: <5149ECA9.9000100@free-electrons.com> (raw)
In-Reply-To: <1363198676-30417-9-git-send-email-sboyd@codeaurora.org>
On 03/13/2013 07:17 PM, Stephen Boyd wrote:
> drivers/clocksource/time-armada-370-xp.c:217:13: warning: symbol
> 'armada_370_xp_timer_init' was not declared. Should it be static?
>
> Also remove the __init marking in the prototype as it's
> unnecessary and drop the init.h file.
>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons•com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora•org>
> ---
> drivers/clocksource/time-armada-370-xp.c | 3 ++-
> include/linux/time-armada-370-xp.h | 4 +---
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
> index 47a6730..efe4aef 100644
> --- a/drivers/clocksource/time-armada-370-xp.c
> +++ b/drivers/clocksource/time-armada-370-xp.c
> @@ -27,10 +27,11 @@
> #include <linux/of_address.h>
> #include <linux/irq.h>
> #include <linux/module.h>
> +#include <linux/percpu.h>
> +#include <linux/time-armada-370-xp.h>
>
> #include <asm/sched_clock.h>
> #include <asm/localtimer.h>
> -#include <linux/percpu.h>
> /*
> * Timer block registers.
> */
> diff --git a/include/linux/time-armada-370-xp.h b/include/linux/time-armada-370-xp.h
> index dfdfdc0..6fb0856 100644
> --- a/include/linux/time-armada-370-xp.h
> +++ b/include/linux/time-armada-370-xp.h
> @@ -11,8 +11,6 @@
> #ifndef __TIME_ARMADA_370_XPPRCMU_H
> #define __TIME_ARMADA_370_XPPRCMU_H
>
> -#include <linux/init.h>
> -
> -void __init armada_370_xp_timer_init(void);
> +void armada_370_xp_timer_init(void);
>
> #endif
>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-03-20 17:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 18:17 [PATCHv3 00/10] Remove ARM local timer API Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 01/10] clocksource: add generic dummy timer driver Stephen Boyd
2013-03-21 18:09 ` Mark Rutland
2013-03-21 18:13 ` Stephen Boyd
2013-03-22 18:03 ` Mark Rutland
2013-03-25 16:49 ` Stephen Boyd
2013-03-25 18:00 ` Mark Rutland
2013-03-25 20:47 ` Thomas Gleixner
2013-03-26 15:26 ` Mark Rutland
2013-03-26 2:14 ` Stephen Boyd
2013-03-26 11:28 ` Mark Rutland
2013-04-05 1:46 ` Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 02/10] ARM: smp: Remove duplicate dummy timer implementation Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 03/10] ARM: smp_twd: Divorce smp_twd from local timer API Stephen Boyd
2013-03-28 15:22 ` Mark Rutland
2013-03-28 20:09 ` Stephen Boyd
2013-04-02 8:41 ` Mark Rutland
2013-03-13 18:17 ` [PATCHv3 04/10] ARM: OMAP2+: Divorce " Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 05/10] ARM: EXYNOS4: Divorce mct " Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 06/10] ARM: PRIMA2: Divorce timer-marco " Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 07/10] ARM: msm: Divorce msm_timer " Stephen Boyd
2013-03-13 18:17 ` [PATCHv3 08/10] clocksource: time-armada-370-xp: Fix sparse warning Stephen Boyd
2013-03-20 17:06 ` Gregory CLEMENT [this message]
2013-03-13 18:17 ` [PATCHv3 09/10] clocksource: time-armada-370-xp: Divorce from local timer API Stephen Boyd
2013-03-20 17:09 ` Gregory CLEMENT
2013-03-20 17:20 ` Stephen Boyd
2013-03-20 17:26 ` Gregory CLEMENT
2013-03-20 17:44 ` Gregory CLEMENT
2013-03-20 18:00 ` Stephen Boyd
2013-03-20 17:21 ` Gregory CLEMENT
2013-03-13 18:17 ` [PATCHv3 10/10] ARM: smp: Remove " Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5149ECA9.9000100@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox