From: maxime.ripard@free-electrons•com (Maxime Ripard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 0/3] clock driver for sunxi
Date: Tue, 26 Mar 2013 10:20:21 +0100 [thread overview]
Message-ID: <51516855.3020609@free-electrons.com> (raw)
In-Reply-To: <20130322164054.834.64867@quantum>
Hi Mike,
Le 22/03/2013 17:40, Mike Turquette a ?crit :
> Quoting Maxime Ripard (2013-03-22 03:22:25)
>> Hi Mike,
>>
>> Le 21/03/2013 22:54, Mike Turquette a ?crit :
>>> Quoting Emilio L?pez (2013-02-25 06:44:25)
>>>> Hello everyone,
>>>>
>>>> This patchset adds basic clock support for sunxi devices. Currently, it
>>>> implements support for the two oscillators, the main PLL, the CPU mux,
>>>> its three divisor clocks and APB1. With this in place, it is possible to
>>>> write a cpufreq driver and have it work, and with a little more code,
>>>> represent the UART clocks correctly (I will be sending a separate
>>>> patchset for this).
>>>>
>>>> I have tested this driver successfully on a Cubieboard (A10, sun4i)
>>>> using the cpufreq driver from the linux-sunxi tree after minor
>>>> modifications (the clock names are not the same).
>>>>
>>>> Any feedback will be highly appreciated
>>>>
>>>
>>> Emilio,
>>>
>>> This is a nice series. I appreciate the amount of comments in the code,
>>> the kerneldoc and also the added sunxi clock documentation.
>>>
>>> Concerning the discussion from the v1 series, I prefer for the struct
>>> clk instances in the tree to match 1-to-1 with hardware clocks. As the
>>> number of clocks in a system scales into the hundreds there are
>>> certainly advantages to having fewer clocks in the hierarchy, not the
>>> least of which is more easily associating these objects with hardware
>>> clocks during a deep debug session.
>>>
>>> That can be changed at a later time if you wish. Do you want me to take
>>> the series into clk-next or do you just want my ack?
>>
>> Thanks for your feedback!
>>
>> Unless you have some objection, I was planning to merge it through my
>> tree, with your Acked-by, of course.
>>
>
> Acked-by: Mike Turquette <mturquette@linaro•org>
Arnd would prefer to get this serie going through your tree, could you
merge the patches 1/3 and 3/3 with my Acked-by?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-03-26 9:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 6:12 [PATCH 0/3] clock driver for sunxi Emilio López
2013-01-22 6:12 ` [PATCH 1/3] clk: arm: sunxi: Add a new clock driver for sunxi SOCs Emilio López
2013-02-05 11:18 ` Gregory CLEMENT
2013-02-08 10:38 ` Emilio López
2013-02-08 11:43 ` Gregory CLEMENT
2013-02-08 11:33 ` Gregory CLEMENT
2013-02-08 17:41 ` Emilio López
2013-02-08 17:51 ` Gregory CLEMENT
2013-01-22 6:12 ` [PATCH 2/3] arm: sunxi: Add clock definitions for the new clock driver Emilio López
2013-01-30 8:24 ` Maxime Ripard
2013-01-30 11:57 ` Emilio López
2013-01-22 6:12 ` [PATCH 3/3] arm: sunxi: Add useful information about sunxi clocks Emilio López
2013-01-30 8:17 ` [PATCH 0/3] clock driver for sunxi Maxime Ripard
2013-02-04 22:03 ` Maxime Ripard
2013-02-25 14:44 ` [PATCH v2 " Emilio López
2013-02-25 14:44 ` [PATCH v2 1/3] clk: arm: sunxi: Add a new clock driver for sunxi SOCs Emilio López
2013-02-25 14:44 ` [PATCH v2 2/3] arm: sunxi: Add clock definitions for the new clock driver Emilio López
2013-02-25 14:44 ` [PATCH v2 3/3] arm: sunxi: Add useful information about sunxi clocks Emilio López
2013-03-04 15:04 ` [PATCH v2 0/3] clock driver for sunxi Emilio López
2013-03-10 11:42 ` Maxime Ripard
2013-03-21 21:54 ` Mike Turquette
2013-03-22 10:22 ` Maxime Ripard
2013-03-22 16:40 ` Mike Turquette
2013-03-23 9:27 ` Maxime Ripard
2013-03-26 9:20 ` Maxime Ripard [this message]
2013-03-27 1:55 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51516855.3020609@free-electrons.com \
--to=maxime.ripard@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox