Subject: [PATCH 05/15] cpuidle: imx6: remove timer broadcast initialization

From: [email-masked] (Daniel Lezcano)
Date: Tue, 26 Mar 2013 10:43:29 +0100

On 03/26/2013 08:25 AM, Shawn Guo wrote:
> On Mon, Mar 25, 2013 at 06:55:30PM +0100, Daniel Lezcano wrote:
>> The initialization is done from the cpuidle framework.
>>
>> Signed-off-by: Daniel Lezcano <[email-masked]>
>> ---
>>  arch/arm/mach-imx/cpuidle-imx6q.c |   15 ---------------
>>  1 file changed, 15 deletions(-)
>>
>> diff --git a/arch/arm/mach-imx/cpuidle-imx6q.c b/arch/arm/mach-imx/cpuidle-imx6q.c
>> index 5ae22f7..a783a63 100644
>> --- a/arch/arm/mach-imx/cpuidle-imx6q.c
>> +++ b/arch/arm/mach-imx/cpuidle-imx6q.c
>> @@ -6,7 +6,6 @@
>>   * published by the Free Software Foundation.
>>   */
>>  
>> -#include <linux/clockchips.h>
> 
> Removing this causes the compile error below.
> 
>   CC      arch/arm/mach-imx/cpuidle-imx6q.o
> arch/arm/mach-imx/cpuidle-imx6q.c: In function ?imx6q_enter_wait?:
> arch/arm/mach-imx/cpuidle-imx6q.c:25:2: error: implicit declaration of function ?clockevents_notify? [-Werror=implicit-function-declaration]
> arch/arm/mach-imx/cpuidle-imx6q.c:25:21: error: ?CLOCK_EVT_NOTIFY_BROADCAST_ENTER? undeclared (first use in this function)
> arch/arm/mach-imx/cpuidle-imx6q.c:25:21: note: each undeclared identifier is reported only once for each function it appears in
> arch/arm/mach-imx/cpuidle-imx6q.c:45:21: error: ?CLOCK_EVT_NOTIFY_BROADCAST_EXIT? undeclared (first use in this function)
> cc1: some warnings being treated as errors
> make[2]: *** [arch/arm/mach-imx/cpuidle-imx6q.o] Error 1

Hi Shawn,

actually this is because the patch applies on top of:

commit 12e849504b861470e5bf991f79c0be71b97c8dac
Author: Daniel Lezcano <[email-masked]>
Date:   Thu Mar 21 12:21:33 2013 +0000

    cpuidle / imx6 : use CPUIDLE_FLAG_TIMER_STOP flag

    Use the CPUIDLE_FLAG_TIMER_STOP and let the cpuidle framework
    to handle the CLOCK_EVT_NOTIFY_BROADCAST_ENTER/EXIT when entering
    this state.

    Signed-off-by: Daniel Lezcano <[email-masked]>
    Acked-by: Santosh Shilimkar <[email-masked]>
    Signed-off-by: Rafael J. Wysocki <[email-masked]>

-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog