From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] RX-51: ARM errata 430973 workaround
Date: Mon, 1 Apr 2013 14:03:41 +0530 [thread overview]
Message-ID: <51594665.1090903@ti.com> (raw)
In-Reply-To: <1364738063-23868-1-git-send-email-pali.rohar@gmail.com>
On Sunday 31 March 2013 07:24 PM, Pali Roh?r wrote:
> Closed and signed Nokia X-Loader bootloader stored in RX-51 nand does not set
> IBE bit in ACTLR and starting kernel in non-secure mode. So direct write to
> ACTLR by our kernel does not working and the code for ARM errata 430973 in
> commit 7ce236fcd6fd45b0441a2d49acb2ceb2de2e8a47 that sets IBE bit is a noop.
>
> In order to have workaround for ARM errata 430973 from non-secure world on
> RX-51 we needs Secure Monitor Call to set IBE BIT in ACTLR.
>
> This patch adds RX-51 specific SMC support and sets IBE bit in ACTLR during
> board init code for ARM errata 430973 workaround.
>
> Because all the setup and what arguments are required for SMC are completely
> different from SoC to SoC it is not possible to create generic SMC handling.
> Code in omap-smc.S looks identical but it is not. So RX-51 needs another code.
>
> ARM errata 430973 workaround is needed for thumb-2 ISA compiled userspace
> binaries. Without this workaround thumb-2 binaries crashing. So with this
> patch it is possible to recompile and run applications/binaries with thumb-2
> ISA on RX-51.
>
> Signed-off-by: Ivaylo Dimitrov <freemangordon@abv•bg>
> Signed-off-by: Pali Roh?r <pali.rohar@gmail•com>
> ---
> arch/arm/mach-omap2/Makefile | 1 +
> arch/arm/mach-omap2/board-rx51-secure.c | 66 +++++++++++++++++++++++++++++++
> arch/arm/mach-omap2/board-rx51-secure.h | 36 +++++++++++++++++
> arch/arm/mach-omap2/board-rx51-smc.S | 34 ++++++++++++++++
> arch/arm/mach-omap2/board-rx51.c | 7 ++++
> 5 files changed, 144 insertions(+)
> create mode 100644 arch/arm/mach-omap2/board-rx51-secure.c
> create mode 100644 arch/arm/mach-omap2/board-rx51-secure.h
> create mode 100644 arch/arm/mach-omap2/board-rx51-smc.S
>
> diff --git a/arch/arm/mach-omap2/board-rx51-smc.S b/arch/arm/mach-omap2/board-rx51-smc.S
> new file mode 100644
> index 0000000..70e2eb7
> --- /dev/null
> +++ b/arch/arm/mach-omap2/board-rx51-smc.S
> @@ -0,0 +1,34 @@
You can avoid creating board-rx51-smc.S by having rx51_ppa_smc()
part of board-rx51-secure.c using inline asm. You can avoid the
board-rx51-secure.h as well considering the usage is limited to
the rx51 board.
Regards,
Santosh
prev parent reply other threads:[~2013-04-01 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <24838523.73311.1364448607026.JavaMail.apache@mail82.abv.bg>
2013-03-28 15:58 ` [PATCH] arm: omap: RX-51: ARM errata 430973 workaround Tony Lindgren
2013-03-31 13:54 ` [PATCH] " Pali Rohár
2013-04-01 8:33 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51594665.1090903@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox