From: dgilbert@interlog•com (Douglas Gilbert)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH] rtc: rtc-at91rm9200: manage IMR depending on revision
Date: Tue, 02 Apr 2013 11:32:27 -0400 [thread overview]
Message-ID: <515AFA0B.7020509@interlog.com> (raw)
In-Reply-To: <1364908007-5150-1-git-send-email-nicolas.ferre@atmel.com>
On 13-04-02 09:06 AM, Nicolas Ferre wrote:
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel•com>
> ---
> Hi all,
>
> The funny thing is that I was writing exactly the same code as Johan's
> when he posted his series.
>
> So, here is my single patch, with the comment about the readback stolen from
> Johan's, but without the way to determine with IP is buggy and which one is
> not...
> After having dug the possibility to read the IP revision, I discovered that it
> is not possible to use this information ("version" register offset changing
> according to... IP version number: well done!).
> In conclusion, I guess that the only way to determine if we need the workaround
> is to use the DT.
> One remark though: if we use the compatibility string for this purpose, I fear
> that we would twist the meaning of this information: SoC using an
> "atmel,at91sam9x5-rtc" compatible RTC will not necessarily be touched by the
> "non responding IMR" bug: at91sam9n12 or upcoming sama5d3 are not affected for
> instance, and we need to cling to "atmel,at91rm9200-rtc" for them...
> I think that we can use this method for the moment and move to another
> compatibility string later if it is needed.
Rather than have so many people working on rtc-at91rm9200.c,
how about someone bring its "RTT" sibling into the DT
world. I'm talking about drivers/rtc/rtc-at91sam9.c ...
Doug Gilbert
next prev parent reply other threads:[~2013-04-02 15:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 16:03 [RFC 1/5] rtc-at91rm9200: add configuration support Johan Hovold
[not found] ` <1364573029-19346-2-git-send-email-jhovold@gmail.com>
2013-03-29 16:12 ` [RFC 2/5] rtc-at91rm9200: add device-tree support Johan Hovold
[not found] ` <1364573029-19346-5-git-send-email-jhovold@gmail.com>
2013-03-29 16:39 ` [RFC 5/5] rtc-at91rm9200: add support for at91sam9x5 Douglas Gilbert
2013-04-02 13:06 ` [RFC PATCH] rtc: rtc-at91rm9200: manage IMR depending on revision Nicolas Ferre
2013-04-02 15:32 ` Douglas Gilbert [this message]
2013-04-02 16:28 ` Nicolas Ferre
2013-04-02 16:36 ` [RFC PATCH v2] " Nicolas Ferre
2013-04-03 9:51 ` Johan Hovold
2013-04-03 9:54 ` [PATCH] Revert "drivers/rtc/rtc-at91rm9200.c: use a variable for storing IMR" Johan Hovold
2013-04-03 10:18 ` Nicolas Ferre
2013-04-05 14:14 ` Nicolas Ferre
2013-04-05 15:35 ` Greg KH
2013-04-05 16:16 ` Nicolas Ferre
2013-04-03 10:37 ` [RFC PATCH v2] rtc: rtc-at91rm9200: manage IMR depending on revision Nicolas Ferre
2013-04-03 13:46 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515AFA0B.7020509@interlog.com \
--to=dgilbert@interlog$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox