From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 2/3] ARM: dts: tegra: add clock source for PMC
Date: Tue, 02 Apr 2013 13:36:21 -0600 [thread overview]
Message-ID: <515B3335.30405@wwwdotorg.org> (raw)
In-Reply-To: <1364901583-24867-3-git-send-email-josephl@nvidia.com>
On 04/02/2013 05:19 AM, Joseph Lo wrote:
> Adding the clock sources of PMC into DTS for Tegra20 and Tegra30.
Why only Tegra20 and Tegra30; don't you need to make the exact same
changes to tegra114-dalmore.dts and tegra114-pluto.dts? (I think the
answer is yes, you do).
> diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> index cb73e62..4c107e6 100644
> --- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> +++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> @@ -8,6 +8,19 @@
> reg = <0x00000000 0x20000000>;
> };
>
> + clocks {
...
> + };
> +
> host1x {
The node order is wrong here. The order should be:
1) Any nodes that existed in any included file, in the same order as
they existed in the included file.
2) Any new nodes that have a reg property, sorted by reg property.
3) Any new nodes without a reg property, sorted alpha-numerically by
node name.
So in this file for example, the new nod should exist between
sdhci at c8000600 and sound.
This same comment applies to every file in this patch.
next prev parent reply other threads:[~2013-04-02 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 11:19 [PATCH V3 0/3] ARM: tegra: add clock source for PMC Joseph Lo
2013-04-02 11:19 ` [PATCH V3 1/3] ARM: tegra: get PMC clock source from DT Joseph Lo
2013-04-02 19:33 ` Stephen Warren
2013-04-02 11:19 ` [PATCH V3 2/3] ARM: dts: tegra: add clock source for PMC Joseph Lo
2013-04-02 19:36 ` Stephen Warren [this message]
2013-04-02 11:19 ` [PATCH V3 3/3] ARM: tegra: moving the CPU power timer function to PMC driver Joseph Lo
2013-04-02 19:37 ` Stephen Warren
2013-04-02 19:42 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515B3335.30405@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox