From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 07/18] ARM: at91: cpuidle: use init/exit common routine
Date: Wed, 10 Apr 2013 16:39:13 +0200 [thread overview]
Message-ID: <51657991.5010205@atmel.com> (raw)
In-Reply-To: <1365603743-5618-8-git-send-email-daniel.lezcano@linaro.org>
On 04/10/2013 04:22 PM, Daniel Lezcano :
> Remove the duplicate code and use the arm cpuidle driver's common code
> for initialization.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro•org>
Seems okay:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel•com>
> ---
> arch/arm/mach-at91/cpuidle.c | 17 ++---------------
> 1 file changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/mach-at91/cpuidle.c b/arch/arm/mach-at91/cpuidle.c
> index 0130df7..48f1228 100644
> --- a/arch/arm/mach-at91/cpuidle.c
> +++ b/arch/arm/mach-at91/cpuidle.c
> @@ -27,8 +27,6 @@
>
> #define AT91_MAX_STATES 2
>
> -static DEFINE_PER_CPU(struct cpuidle_device, at91_cpuidle_device);
> -
> /* Actual code that puts the SoC in different idle states */
> static int at91_enter_idle(struct cpuidle_device *dev,
> struct cpuidle_driver *drv,
> @@ -60,20 +58,9 @@ static struct cpuidle_driver at91_idle_driver = {
> };
>
> /* Initialize CPU idle by registering the idle states */
> -static int at91_init_cpuidle(void)
> +static int __init at91_init_cpuidle(void)
> {
> - struct cpuidle_device *device;
> -
> - device = &per_cpu(at91_cpuidle_device, smp_processor_id());
> - device->state_count = AT91_MAX_STATES;
> -
> - cpuidle_register_driver(&at91_idle_driver);
> -
> - if (cpuidle_register_device(device)) {
> - printk(KERN_ERR "at91_init_cpuidle: Failed registering\n");
> - return -EIO;
> - }
> - return 0;
> + return cpuidle_register(&at91_idle_driver, NULL);
> }
>
> device_initcall(at91_init_cpuidle);
>
--
Nicolas Ferre
next prev parent reply other threads:[~2013-04-10 14:39 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 14:22 [PATCH 00/18] cpuidle: code consolidation Daniel Lezcano
2013-04-10 14:22 ` [PATCH 01/18] ARM: OMAP3: remove cpuidle_wrap_enter Daniel Lezcano
2013-04-10 14:22 ` [PATCH 02/18] cpuidle: remove en_core_tk_irqen flag Daniel Lezcano
2013-04-10 14:22 ` [PATCH 03/18] ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpu Daniel Lezcano
2013-04-10 14:22 ` [PATCH 04/18] ARM: imx: cpuidle: create separate drivers for imx5/imx6 Daniel Lezcano
2013-04-12 6:05 ` Shawn Guo
2013-04-12 6:58 ` Daniel Lezcano
2013-04-12 7:11 ` Shawn Guo
2013-04-12 7:12 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 05/18] cpuidle: make a single register function for all Daniel Lezcano
2013-04-10 14:59 ` Rob Herring
2013-04-10 15:05 ` Daniel Lezcano
2013-04-22 6:57 ` Daniel Lezcano
2013-04-10 16:55 ` Andrew Lunn
2013-04-10 18:04 ` Daniel Lezcano
2013-04-10 18:18 ` Andrew Lunn
2013-04-10 22:07 ` Daniel Lezcano
2013-04-10 17:04 ` Andrew Lunn
2013-04-10 18:02 ` Daniel Lezcano
2013-04-10 18:23 ` Andrew Lunn
2013-04-10 19:59 ` Daniel Lezcano
2013-04-10 18:22 ` Colin Cross
2013-04-10 19:59 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 06/18] ARM: ux500: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-10 14:22 ` [PATCH 07/18] ARM: at91: " Daniel Lezcano
2013-04-10 14:39 ` Nicolas Ferre [this message]
2013-04-10 14:22 ` [PATCH 08/18] ARM: OMAP3: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 09/18] ARM: s3c64xx: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 10/18] ARM: tegra1: " Daniel Lezcano
2013-04-10 17:29 ` Stephen Warren
2013-04-10 18:05 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 11/18] ARM: shmobile: " Daniel Lezcano
2013-04-11 2:46 ` Simon Horman
2013-04-10 14:22 ` [PATCH 12/18] ARM: OMAP4: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 13/18] ARM: tegra2: " Daniel Lezcano
2013-04-11 1:01 ` Joseph Lo
2013-04-11 5:58 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 14/18] ARM: tegra3: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 15/18] ARM: calxeda: " Daniel Lezcano
2013-04-10 14:31 ` Rob Herring
2013-04-10 14:22 ` [PATCH 16/18] ARM: kirkwood: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 17/18] ARM: davinci: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 18/18] ARM: imx: " Daniel Lezcano
2013-04-10 19:12 ` [PATCH 00/18] cpuidle: code consolidation Rafael J. Wysocki
2013-04-10 20:01 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51657991.5010205@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox