From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support
Date: Fri, 12 Apr 2013 09:34:13 -0600 [thread overview]
Message-ID: <51682975.1080302@wwwdotorg.org> (raw)
In-Reply-To: <C79B248886DD134989C8FF6B096A91AB91B36FB2FD@BGMAIL01.nvidia.com>
On 04/12/2013 08:58 AM, Jay Agarwal wrote:
>>> err = regulator_disable(pcie->pex_clk_supply);
>>> if (err < 0)
>>> - dev_err(pcie->dev, "failed to disable pex-clk regulator:
>> %d\n",
>>> + dev_warn(pcie->dev, "failed to disable pex-clk regulator:
>> %d\n",
>>> err);
>>>
>>> err = regulator_disable(pcie->vdd_supply);
>>> if (err < 0)
>>> - dev_err(pcie->dev, "failed to disable VDD regulator: %d\n",
>>> + dev_warn(pcie->dev, "failed to disable VDD regulator:
>> %d\n",
>>> err);
>>
>> Please explain why that change is correct. If the regulators only exist on
>> Tegra20, please represent that fact in the SoC data. Regulators must always
>> exist, so enable/disable should never fail due to missing regulators. Actual
>> run-time failures seem like something that really is an error.
>>
> [>] These regulators are needed for both tegra20 & tegra30. Since we are not returning error here, so changed to dev_warn.
If the regulators are required, then any failure to operate them should
be an error, hence dev_err() seems correct.
As to why the code doesn't actually return an error? I'm not sure.
Perhaps that should be fixed with a separate patch, although I don't
recall exactly where in the code the above excerpt is; if it's in
remove(), then continuing on without returning an error would be
appropriate.
next prev parent reply other threads:[~2013-04-12 15:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 15:41 [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support Jay Agarwal
2013-04-08 15:41 ` [PATCH 2/3] ARM: dts: tegra: Correct PCIe entry Jay Agarwal
2013-04-08 18:27 ` Stephen Warren
2013-04-09 8:30 ` Peter De Schrijver
2013-04-09 15:46 ` Stephen Warren
2013-04-12 15:03 ` Jay Agarwal
2013-04-08 15:41 ` [PATCH 3/3] ARM: dts: tegra: Add PCIe entry for cardhu Jay Agarwal
2013-04-08 18:32 ` Stephen Warren
2013-04-08 18:11 ` [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support Stephen Warren
2013-04-12 14:58 ` Jay Agarwal
2013-04-12 15:34 ` Stephen Warren [this message]
2013-04-13 10:23 ` Thierry Reding
2013-04-08 18:21 ` Stephen Warren
2013-04-12 16:43 ` Jay Agarwal
2013-04-12 17:01 ` Stephen Warren
2013-04-12 17:06 ` Jay Agarwal
2013-04-12 18:29 ` Stephen Warren
2013-04-10 17:23 ` Stephen Warren
2013-05-06 19:49 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51682975.1080302@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox