From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3] ARM: at91: add Acme Systems Aria G25 board
Date: Thu, 18 Apr 2013 11:01:37 +0200 [thread overview]
Message-ID: <516FB671.2030706@atmel.com> (raw)
In-Reply-To: <515DB248.6070105@interlog.com>
On 04/04/2013 07:03 PM, Douglas Gilbert :
> On 13-04-04 11:42 AM, Nicolas Ferre wrote:
>> From: Douglas Gilbert <dgilbert@interlog•com>
>>
>> Signed-off-by: Douglas Gilbert <dgilbert@interlog•com>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel•com>
>> ---
>> Hi all,
>>
>> Here is the third revision of this patch. I plan to include it in a
>> pull-request real-soon-now!
>>
>> v3: - move to "at91-" prefix for .dts[i] files
>> - remove the rtc activation code because of the ongoing discussions
>> about this IP and its DT binding.
>>
>
> Nicolas,
> It's a pity that the rtc activation code is removed.
> At worst:
> rtc at fffffeb0 {
> status = "okay";
> };
I try to re-enalbe it when the at91sam9x5.dtsi exposes a compatibility
sting != at91rm9200-rtc
will soon appear on mailing-list.
> does nothing. Also it is unlikely to be changed by any
> movement on the rtc-at91rm9200 front.
>
>
> The lack of use of uart1 is for my own, private reasons.
> I think it would be more generally useful to show uart1's
> definition and disable it as shown in the attached patch
> fragment.
Well, if uart1 is available on Aria board, I should enable it! If you do
not want it on your own design, you must modify the .dts yourself. So I
plan to have an "okay" status on it (and move the definition itself to
the generic .dtsi).
> I also note that my date line was removed. I like dates,
> so when I add comments like "the i2c-at91 driver is broken
> for the SAM9G20 ** and use the i2c-gpio driver instead" then
> this is not taken as an eternal truth.
Yep, I see, but I try to cleanup the patch as much as I can. If you want
it untouched, provide me a standard formated patch.
> It worked in the
> past and hopefully it will work again in the future.
>
> While on the subject of I2C, I'm getting tired of seeing
> this oft-copied line:
> i2c-gpio,delay-us = <2>; /* ~100 kHz */
>
> It is the clock half period in microseconds and for the 100 kHz
> (standard) I2C clock speed, it should be 5. Due to rounding
> (up) that gives a measured clock speed of around 88 kHz on
> my equipment. Crappy I2C devices *** seem to cope better
> with 12% below the standard clock frequency than 80% above
> it.
Makes sense: I keep it in mind. In parallel, it can be interesting if
you can send me a patch with all these mistakes corrected ;-)
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2013-04-18 9:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 14:59 [GIT PULL] at91: DT changes for 3.10 #2 Nicolas Ferre
2013-04-02 18:49 ` Olof Johansson
2013-04-03 7:45 ` Nicolas Ferre
2013-04-04 9:37 ` Nicolas Ferre
2013-04-04 17:19 ` Olof Johansson
2013-04-08 11:52 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-04 15:42 ` [PATCH v3] ARM: at91: add Acme Systems Aria G25 board Nicolas Ferre
2013-04-04 17:03 ` Douglas Gilbert
2013-04-18 9:01 ` Nicolas Ferre [this message]
2013-04-18 10:13 ` Nicolas Ferre
2013-04-04 16:59 ` [GIT PULL] at91: DT changes for 3.10 #3 Nicolas Ferre
2013-04-09 8:17 ` Nicolas Ferre
2013-04-09 9:47 ` Arnd Bergmann
2013-04-09 10:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516FB671.2030706@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox