From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/5] ARM: at91: at91sam9x5 RTC is not compatible with at91rm9200 one
Date: Fri, 19 Apr 2013 17:05:38 +0200 [thread overview]
Message-ID: <51715D42.5040706@atmel.com> (raw)
In-Reply-To: <51715988.9060606@cogentembedded.com>
On 04/19/2013 04:49 PM, Sergei Shtylyov :
> On 19-04-2013 18:05, Nicolas Ferre wrote:
>
>>>> Due to a bug with RTC IMR, we cannot consider at91sam9x5 RTC compatible
>>>> with the previous one. Modify DT compatibility string, even if the
>>>> driver
>>>> is not yet modified to take it into account.
>
>>>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel•com>
>>>> ---
>>>> arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>>>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi
>>>> b/arch/arm/boot/dts/at91sam9x5.dtsi
>>>> index a3d4464..58747f3 100644
>>>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>>>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>>>> @@ -564,7 +564,7 @@
>>>> };
>>>>
>>>> rtc at fffffeb0 {
>>>> - compatible = "atmel,at91rm9200-rtc";
>>>> + compatible = "atmel,at91sam9x5-rtc";
>
>>> Do not use wildcards in the "compatible" prop values (I guess 'x' is
>>> a wildcard).
>
>> Well, it is for naming a series of hardware, not for giving a generic
>> name that could cover different hardware.
>
>> In the sense of Atmel it is our way to call the at91sam9x5 series of
>> SoC: you will see that the code that covers these SoCs is always named
>> like this.
>> In fact, the hardware contained in these SoC cannot be different from
>> one flavor of the family to the other.
>
> Nevertheless, the wildcards shouldn't be used. Use the name of e.g.
> the first member of the family.
There is not "first" there is no "last" they are all the same from a
hardware perspective. The only difference is activation of peripherals.
So, no, we will not change this.
Cf:
find arch/arm/boot/dts/ | xargs grep compatible | grep at91sam9x5
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2013-04-19 15:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 13:01 [PATCH 0/5] ARM: at91: some more DT enhancements Nicolas Ferre
2013-04-18 13:01 ` [PATCH 1/5] ARM: at91: at91sam9x5 RTC is not compatible with at91rm9200 one Nicolas Ferre
2013-04-19 13:53 ` Sergei Shtylyov
2013-04-19 14:05 ` Nicolas Ferre
2013-04-19 14:49 ` Sergei Shtylyov
2013-04-19 14:57 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-19 15:05 ` Nicolas Ferre [this message]
2013-04-18 13:01 ` [PATCH 2/5] ARM: at91/at91-ariag25.dts: add RTC node Nicolas Ferre
2013-04-18 13:01 ` [PATCH 3/5] ARM: at91/at91sam9x5.dtsi: add UART0/1 nodes Nicolas Ferre
2013-04-18 13:01 ` [PATCH 4/5] ARM: at91/at91-ariag25.dts: UART0/1 nodes are disabled Nicolas Ferre
2013-04-18 13:01 ` [PATCH 5/5] ARM: at91: add Acme Systems Fox G20 board Nicolas Ferre
2013-04-18 16:34 ` Nicolas Ferre
2013-04-19 8:49 ` Nicolas Ferre
2013-04-19 10:40 ` [PATCH 5/5 v2] " Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51715D42.5040706@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox