From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/6] at_hdmac: move to generic DMA binding
Date: Mon, 29 Apr 2013 15:28:41 +0200 [thread overview]
Message-ID: <517E7589.5030205@atmel.com> (raw)
In-Reply-To: <20130423034407.GY24632@intel.com>
On 04/23/2013 05:44 AM, Vinod Koul :
> On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote:
>> On 04/19/2013 11:11 AM, ludovic.desroches at atmel.com :
>>> From: Ludovic Desroches <ludovic.desroches@atmel•com>
>
>>> +#ifdef CONFIG_OF
>>> +static bool at_dma_filter(struct dma_chan *chan, void *slave)
> this is not defined for else case here. Also this could be CONFIG_DMA_OF...?
in fact, at_dma_filter() is only used in corresponding
dma_request_channel() in at_dma_xlate() function just below and only in
case of CONFIG_OF.
As the at_dma_xlate() is an empty function in !CONFIG_OF case, the
at_dma_filter() is not needed.
For the use of CONFIG_OF and not CONFIG_OF_DMA, it is simply because it
it the directive that we currently use in drivers when we have to put
the device tree condition around a piece of code. It is quite a common
pattern I think.
Moreover, it is what is used in dw_dmac.c and mv_xor.c...
>>> +{
>>> + struct at_dma_slave *atslave = slave;
>>> +
>>> + if (atslave->dma_dev == chan->device->dev) {
>>> + chan->private = atslave;
>>> + return true;
>>> + } else {
>>> + return false;
>>> + }
>>> +}
>
> --
> ~Vinod
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2013-04-29 13:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 9:11 [PATCH v3 0/6] ARM: at91: move to generic DMA device tree binding ludovic.desroches at atmel.com
2013-04-19 9:11 ` [PATCH v3 1/6] at_hdmac: move to generic DMA binding ludovic.desroches at atmel.com
2013-04-22 10:22 ` Nicolas Ferre
2013-04-23 3:44 ` Vinod Koul
2013-04-29 13:28 ` Nicolas Ferre [this message]
2013-04-30 8:48 ` Vinod Koul
2013-04-19 9:11 ` [PATCH v3 2/6] ARM: at91: dts: set #dma-cells to the correct value ludovic.desroches at atmel.com
2013-04-19 9:39 ` Nicolas Ferre
2013-04-19 9:11 ` [PATCH v3 3/6] i2c: at91: convert to dma_request_slave_channel_compat() ludovic.desroches at atmel.com
2013-04-19 9:11 ` [PATCH v3 4/6] ARM: at91: dts: add i2c dma support ludovic.desroches at atmel.com
2013-04-19 9:43 ` Nicolas Ferre
2013-04-19 9:11 ` [PATCH v3 5/6] mci: at91: convert to dma_request_slave_channel_compat() ludovic.desroches at atmel.com
2013-04-30 8:06 ` Nicolas Ferre
2013-05-10 10:05 ` [PATCH] mmc: atmel-mci: " Nicolas Ferre
2013-05-26 17:34 ` Chris Ball
2013-04-19 9:11 ` [PATCH v3 6/6] ARM: at91: dts: add MCI DMA support ludovic.desroches at atmel.com
2013-04-19 9:43 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517E7589.5030205@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox