From: Heiko Stuebner <heiko@sntech•de>
To: Daniel Lezcano <daniel.lezcano@linaro•org>
Cc: Mark Rutland <mark.rutland@arm•com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger•kernel.org>,
Emil Renner Berthing <kernel@esmil•dk>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists•infradead.org>,
Tony Xie <tony.xie@rock-chips•com>,
Viresh Kumar <viresh.kumar@linaro•org>,
Randy Li <ayaka@soulik•info>,
linux-kernel@vger•kernel.org, Vicente Bergas <vicencb@gmail•com>,
dianders@chromium•org, edubezval@gmail•com,
Enric Balletbo i Serra <enric.balletbo@collabora•com>,
Rob Herring <robh+dt@kernel•org>,
Klaus Goger <klaus.goger@theobroma-systems•com>,
manivannan.sadhasivam@linaro•org,
Matthias Brugger <matthias.bgg@gmail•com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems•com>,
robin.murphy@arm•com,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists•infradead.org>,
Christoph Muellner <christoph.muellner@theobroma-systems•com>
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi
Date: Fri, 14 Jun 2019 11:35:25 +0200 [thread overview]
Message-ID: <5188064.YWmxIpmbGp@phil> (raw)
In-Reply-To: <20190604165802.7338-1-daniel.lezcano@linaro.org>
Hi Daniel,
Am Dienstag, 4. Juni 2019, 18:57:57 CEST schrieb Daniel Lezcano:
> Currently the common thermal zones definitions for the rk3399 assumes
> multiple thermal zones are supported by the governors. This is not the
> case and each thermal zone has its own governor instance acting
> individually without collaboration with other governors.
>
> As the cooling device for the CPU and the GPU thermal zones is the
> same, each governors take different decisions for the same cooling
> device leading to conflicting instructions and an erratic behavior.
>
> As the cooling-maps is about to become an optional property, let's
> remove the cpu cooling device map from the GPU thermal zone.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro•org>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 196ac9b78076..e1357e0f60f7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -821,15 +821,6 @@
> type = "critical";
> };
> };
> -
> - cooling-maps {
> - map0 {
> - trip = <&gpu_alert0>;
> - cooling-device =
> - <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> - <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> - };
> - };
> };
> };
my knowledge of the thermal framework is not that big, but what about the
rk3399-devices which further detail the cooling-maps like rk3399-gru-kevin
and the rk3399-nanopc-t4 with its fan-handling in the cooling-maps?
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-14 9:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 16:57 [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi Daniel Lezcano
2019-06-04 16:57 ` [PATCH 2/2] arm64: dts: rockchip: Define values for the IPA governor for rock960 Daniel Lezcano
2019-06-07 22:18 ` Linus Walleij
2019-06-08 22:05 ` Daniel Lezcano
2019-06-12 14:55 ` [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi Daniel Lezcano
2019-06-14 9:35 ` Heiko Stuebner [this message]
2019-06-14 10:09 ` Robin Murphy
2019-06-14 13:03 ` Daniel Lezcano
2019-06-14 14:02 ` Robin Murphy
2019-06-14 14:30 ` Daniel Lezcano
2019-06-16 9:31 ` Krzysztof Kozlowski
2019-06-16 17:47 ` Daniel Lezcano
2019-06-24 7:31 ` Daniel Lezcano
2019-06-26 22:26 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5188064.YWmxIpmbGp@phil \
--to=heiko@sntech$(echo .)de \
--cc=ayaka@soulik$(echo .)info \
--cc=christoph.muellner@theobroma-systems$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dianders@chromium$(echo .)org \
--cc=edubezval@gmail$(echo .)com \
--cc=enric.balletbo@collabora$(echo .)com \
--cc=kernel@esmil$(echo .)dk \
--cc=klaus.goger@theobroma-systems$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=philipp.tomsich@theobroma-systems$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=tony.xie@rock-chips$(echo .)com \
--cc=vicencb@gmail$(echo .)com \
--cc=viresh.kumar@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox