From: james.hogan@imgtec•com (James Hogan)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/4] clk: add support for clock reparent on set_rate
Date: Thu, 16 May 2013 10:35:39 +0100 [thread overview]
Message-ID: <5194A86B.6000207@imgtec.com> (raw)
In-Reply-To: <5193EF34.7070800@codeaurora.org>
On 15/05/13 21:25, Stephen Boyd wrote:
> On 05/15/13 06:41, James Hogan wrote:
>> Each place where round_rate() is called, determine_rate is checked first
>> and called in preference, passing NULL to the new parent argument if not
>> needed (e.g. in __clk_round_rate).
>
> That's annoying. Even if we don't care about the pointer in
> clk_round_rate(), this requires the ops to check for NULL before
> assigning the pointer. Why not just pass an unused pointer that the ops
> can assign all the time?
True, I'll fix that.
> With the above change you can add
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora•org>
Thanks for taking the time to review it.
Cheers
James
next prev parent reply other threads:[~2013-05-16 9:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 13:40 [PATCH v3 0/4] clk: implement remuxing during set_rate James Hogan
2013-05-15 13:41 ` [PATCH v3 1/4] clk: abstract parent cache James Hogan
2013-05-15 20:25 ` Stephen Boyd
2013-05-15 13:41 ` [PATCH v3 2/4] clk: add support for clock reparent on set_rate James Hogan
2013-05-15 20:25 ` Stephen Boyd
2013-05-16 9:35 ` James Hogan [this message]
2013-05-20 4:15 ` Stephen Boyd
2013-05-20 9:13 ` James Hogan
2013-05-15 13:41 ` [PATCH v3 3/4] clk: add CLK_SET_RATE_NO_REPARENT flag James Hogan
2013-05-15 13:41 ` [PATCH v3 4/4] clk: clk-mux: implement remuxing on set_rate James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5194A86B.6000207@imgtec.com \
--to=james.hogan@imgtec$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox