public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: srinivas.kandagatla@st•com (Srinivas KANDAGATLA)
To: linux-arm-kernel@lists•infradead.org
Subject: ux500 breaking multi-platform kernels
Date: Fri, 17 May 2013 09:57:07 +0100	[thread overview]
Message-ID: <5195F0E3.6020402@st.com> (raw)
In-Reply-To: <CAL_JsqJzf8Aj6+K_qEYo3JbAoeJn36EerBfaGYT9EQj-zPaHUw@mail.gmail.com>

On 15/05/13 21:30, Rob Herring wrote:
> @@ -39,10 +39,10 @@ static int __init ux500_l2x0_init(void)
>  {
>         u32 aux_val = 0x3e000000;
> 
> -       if (cpu_is_u8500_family() || cpu_is_ux540_family())
> -               l2x0_base = __io_address(U8500_L2CC_BASE);
> -       else
> -               ux500_unknown_soc();
> +       if (!(cpu_is_u8500_family() || cpu_is_ux540_family()))
> +               return -ENODEV;
> +
> +       l2x0_base = __io_address(U8500_L2CC_BASE);

I think moving
early_initcall(ux500_l2x0_init);

to
MACHINE
.init_early = ux500_l2x0_init

should solve this issue neatly.


--srini

      parent reply	other threads:[~2013-05-17  8:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 20:30 ux500 breaking multi-platform kernels Rob Herring
2013-05-16  7:43 ` Lee Jones
2013-05-16  7:48   ` Lee Jones
2013-05-17  6:29 ` Linus Walleij
2013-05-17  8:00   ` Lee Jones
2013-05-17 19:23   ` Rob Herring
2013-05-17  8:57 ` Srinivas KANDAGATLA [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5195F0E3.6020402@st.com \
    --to=srinivas.kandagatla@st$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox