Subject: [PATCH v4 21/32] arm64: KVM: Build system integration

From: [email-masked] (Marc Zyngier)
Date: Tue, 21 May 2013 17:14:07 +0100

On 21/05/13 17:09, Paolo Bonzini wrote:
> 
> 
> ----- Messaggio originale -----
>> Da: "Catalin Marinas" <[email-masked]>
>> A: "Marc Zyngier" <[email-masked]>
>> Cc: linux-arm-kernel at lists.infradead.org, kvmarm at lists.cs.columbia.edu, kvm at vger.kernel.org, "Will Deacon"
>> <[email-masked]>, pbonzini at redhat.com, gleb at redhat.com, "Christopher Covington" <[email-masked]>
>> Inviato: Marted?, 21 maggio 2013 17:42:27
>> Oggetto: Re: [PATCH v4 21/32] arm64: KVM: Build system integration
>>
>> On Tue, May 14, 2013 at 03:13:49PM +0100, Marc Zyngier wrote:
>>> --- /dev/null
>>> +++ b/arch/arm64/kvm/Kconfig
>> ...
>>> +config KVM_ARM_VGIC
>>> +        bool
>>> +	depends on KVM_ARM_HOST && OF
>>> +	select HAVE_KVM_IRQCHIP
>>> +	---help---
>>> +	  Adds support for a hardware assisted, in-kernel GIC emulation.
>>> +
>>> +config KVM_ARM_TIMER
>>> +        bool
>>> +	depends on KVM_ARM_VGIC
>>> +	select HAVE_KVM_IRQCHIP
>>> +	---help---
>>> +	  Adds support for the Architected Timers in virtual machines
>>> +
>>> +source drivers/virtio/Kconfig
>>
>> Shouldn't the above configs go to drivers/virtio/Kconfig as well (or
>> drivers/virtio/arm/Kconfig)?
> 
> virtio doesn't mean "virtual versions of devices that also exist in
> hardware"; those are indeed in arch/ARCH/kvm.  virtio is a specific bus
> for paravirtualized devices.  It is not KVM-specific and the code runs
> in the guest (whereas arch/arm64/kvm/Kconfig is host code).
> 
> That said, drivers/virtio/Kconfig is already sourced by drivers/Kconfig.
> Why do you need to source it again here?

Probably some brain fart on my side. I'll get rid of it.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...