From: rogerq@ti•com (Roger Quadros)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci
Date: Thu, 30 May 2013 14:45:28 +0300 [thread overview]
Message-ID: <51A73BD8.8000007@ti.com> (raw)
In-Reply-To: <20130529173715.GB21290@arwen.pp.htv.fi>
On 05/29/2013 08:37 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, May 29, 2013 at 11:58:01AM +0800, Chao Xie wrote:
>> On Wed, May 29, 2013 at 12:24 AM, Felipe Balbi <balbi@ti•com> wrote:
>>> Hi,
>>>
>>> On Mon, May 13, 2013 at 10:13:44AM -0400, Alan Stern wrote:
>>>> On Mon, 13 May 2013, Chao Xie wrote:
>>>>
>>>>> Originaly, ehci driver will call the callbacks in platform data
>>>>> for PHY initialization and shut down.
>>>>> With PHY driver, it will call the APIs provided by PHY driver
>>>>> for PHY initialization and shutdown. It removes the callbacks
>>>>> in platform data, and at same time it removes one block in the
>>>>> way of enabling device tree for ehci driver.
>>>>
>>>> I wonder if this is the sort of thing that should be handled in
>>>> ehci-hcd.c rather than in all the different platform glue drivers.
>>>>
>>>> Felipe, what do you think? Are the required actions now sufficiently
>>>> generic that a single source file can take care of them?
>>>
>>> Sorry for the delay, was on business trip and now on vacations. Anyway,
>>> I agree with you. Our PHY layer should be generic enough that it should
>>> be usable by ehci-hcd itself. If we have any missing method, let's add
>>> it generically.
>>>
>> So what are your idea about making the PHY layer more generic? How
>> ehci-hcd will make use of PHY layer?
>
>
> on probe grab the phy and initialize it. On suspend/resume,
> suspend/resume the PHY and so on. Whatever you were going to do on your
> ehci glue, do it on generic ehci-hcd.
>
These operations sound generic enough to be done at HCD layer, no? So no need to
replicate the same stuff in ohci, ehci, xhci, etc.
cheers,
-roger
next prev parent reply other threads:[~2013-05-30 11:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 5:51 [V9 PATCH 00/12] mv-usb phy driver Chao Xie
2013-05-13 5:51 ` [PATCh V10 01/12] usb: phy: protect phy init and shutdown for mutiple deivces Chao Xie
2013-05-13 5:51 ` [PATCh V10 02/12] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller Chao Xie
2013-05-13 5:51 ` [PATCh V10 03/12] usb: gadget: mv_udc: use PHY driver for udc Chao Xie
2013-05-13 5:51 ` [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci Chao Xie
2013-05-13 14:13 ` Alan Stern
2013-05-28 16:24 ` Felipe Balbi
2013-05-29 3:58 ` Chao Xie
2013-05-29 17:37 ` Felipe Balbi
2013-05-30 11:45 ` Roger Quadros [this message]
2013-05-30 14:23 ` Alan Stern
2013-06-13 2:45 ` Chao Xie
2013-06-13 15:08 ` Alan Stern
2013-06-14 1:31 ` Chao Xie
2013-06-14 1:55 ` Chao Xie
2013-06-15 2:24 ` Alan Stern
2013-06-14 9:07 ` Roger Quadros
2013-06-14 20:01 ` Alan Stern
2013-06-17 6:12 ` Chao Xie
2013-06-17 14:01 ` Alan Stern
2013-06-17 8:17 ` Roger Quadros
2013-05-13 5:51 ` [PATCh V10 05/12] usb: phy: phy-mv-usb: use USB2 PHY driver for otg Chao Xie
2013-05-13 5:51 ` [PATCh V10 06/12] usb: mv_u3d: usb phy drivers for phy operation Chao Xie
2013-05-13 5:51 ` [PATCh V10 07/12] arm: mmp2: change the defintion of usb devices Chao Xie
2013-05-13 5:51 ` [PATCh V10 08/12] arm: pxa910: " Chao Xie
2013-05-13 5:51 ` [PATCh V10 09/12] arm: ttc_dkb: modify usb support Chao Xie
2013-05-13 5:51 ` [PATCh V10 10/12] arm: mmp: remove unused usb devices Chao Xie
2013-05-13 5:51 ` [PATCh V10 11/12] arm: brownstone: add usb support for the board Chao Xie
2013-05-13 5:51 ` [PATCh V10 12/12] usb: mv_usb: remove the phy callbacks in pdata Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A73BD8.8000007@ti.com \
--to=rogerq@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox