From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V4 2/4] ARM: tegra: pcie: Add tegra3 support
Date: Wed, 05 Jun 2013 10:36:01 -0600 [thread overview]
Message-ID: <51AF68F1.8080307@wwwdotorg.org> (raw)
In-Reply-To: <1370445221-17696-1-git-send-email-jagarwal@nvidia.com>
On 06/05/2013 09:13 AM, Jay Agarwal wrote:
> - Make private data structure for each SoC
> - Add required Tegra30 clocks and regulators
> - Add Tegra30 specific code in enable controller
> - Added Tegra30 specific properties in pci binding document
It's a bit odd to send an updated version of just some of the patches;
reposting a whole series is much easier for the person applying the
patches. However, hopefully Thierry can handle it in this case.
> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> Required properties:
> -- compatible: "nvidia,tegra20-pcie"
> +- compatible: "nvidia,tegra20-pcie" "nvidia,tegra30-pcie"
perhaps add "or" between those two entries?
> +- avdd-supply: Power supply for controller (1.05V) (not required for tegra20)
...
> + "cml": The Tegra clock of that name (not required for tegra20)
Tegra20 should be capitalized in both those two lines.
I assume that Thierry can fix up these nits when he applies the patches,
so you don't need to repost. Thierry can correct me if I'm wrong.
next prev parent reply other threads:[~2013-06-05 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 15:13 [PATCH V4 2/4] ARM: tegra: pcie: Add tegra3 support Jay Agarwal
2013-06-05 16:36 ` Stephen Warren [this message]
2013-06-10 20:09 ` Thierry Reding
2013-06-11 4:47 ` Jay Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF68F1.8080307@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox