public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: r.sricharan@ti•com (Sricharan R)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 14/14] ARM: OMAP4: hwmod data: Clean up the data file
Date: Fri, 7 Jun 2013 16:37:32 +0530	[thread overview]
Message-ID: <51B1BEF4.6080606@ti.com> (raw)
In-Reply-To: <51B1B936.5030302@ti.com>

Hi Benoit,

On Friday 07 June 2013 04:13 PM, Benoit Cousson wrote:
> Hi Sricharan,
>
> On 06/07/2013 12:27 PM, Sricharan R wrote:
>> - The IO resource information like dma request lines, irq number and
>>   ocp address space can be populated via dt blob. So such data is stripped
>>   from OMAP4 SOC hwmod data file.
>>
>> - The devices which are still missing the device tree bindings,
>>   address space entries are not removed yet. When such devices add
>>   the dt bindings, respective address space data can be deleted.
>>
>> - Also other unnessecary hwmods like firewalls are removed as a part of this.
> typo.
 Ok, will correct.

> That part is fine, but you should add that by doing that you have to
> create new direct link from MPU to EMIFs that did no exist before.
 Yes, the mpu->emif link is already added in the patch

>> The above update, results in reduction of about ~1650 lines of code.
>>
>> The comment about autogeneration is removed temporarily. Should be brought
>> back after syncing the scripts.
> You'd better keep it and append a note stating that.
> If you remove it, I fairly know nobody will ever add it again :-)
 Ok, will change this then :-)
> Otherwise the patch looks fine.
>
> Thanks,
> Benoit
Regards,
 Sricharan

  parent reply	other threads:[~2013-06-07 11:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 10:27 [PATCH 14/14] ARM: OMAP4: hwmod data: Clean up the data file Sricharan R
     [not found] ` <51B1B936.5030302@ti.com>
2013-06-07 11:07   ` Sricharan R [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-05-29 16:38 [PATCH 00/14] ARM: OMAP5: hwmod, prm/cm data files and updates for 3.11 Santosh Shilimkar
2013-05-29 16:38 ` [PATCH 14/14] ARM: OMAP4: hwmod data: Clean up the data file Santosh Shilimkar
2013-06-06 17:57   ` Paul Walmsley
2013-06-06 18:30     ` Santosh Shilimkar
2013-06-07  5:55       ` Sricharan R
2013-06-07  7:52         ` Paul Walmsley
2013-06-07  9:01           ` Sricharan R
2013-06-07  9:46             ` Tero Kristo
2013-06-07  9:50               ` Paul Walmsley
2013-06-07  9:53                 ` Sricharan R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B1BEF4.6080606@ti.com \
    --to=r.sricharan@ti$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox