From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/3] ARM: tegra: basic support for Trusted Foundations
Date: Thu, 13 Jun 2013 13:19:29 -0600 [thread overview]
Message-ID: <51BA1B41.6030002@wwwdotorg.org> (raw)
In-Reply-To: <1371114745-24710-2-git-send-email-acourbot@nvidia.com>
On 06/13/2013 03:12 AM, Alexandre Courbot wrote:
> Add basic support for booting secondary processors on Tegra devices
> using the Trusted Foundations secure monitor.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia•com>
> ---
> Documentation/devicetree/bindings/arm/tegra.txt | 11 +++++
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> arch/arm/configs/tegra_defconfig | 1 +
The defconfig change should be a separate patch, so that I can squash it
into any other defconfig updates separately from all the code changes.
> diff --git a/arch/arm/mach-tegra/firmware.c b/arch/arm/mach-tegra/firmware.c
> +void __init tegra_init_firmware(void)
> +{
> + struct device_node *node;
> +
> + if (!of_have_populated_dt())
> + return;
> +
> + node = of_find_compatible_node(NULL, NULL, "tl,trusted-foundations");
> + if (node && !IS_ENABLED(CONFIG_TEGRA_TRUSTED_FOUNDATIONS))
> + pr_warn("Trusted Foundations detected but support missing!\n");
> +#if IS_ENABLED(CONFIG_TEGRA_TRUSTED_FOUNDATIONS)
> + else if (node)
> + register_firmware_ops(&tegra_trusted_foundations_ops);
> +#endif
> +}
Is it worth continuing on in the node && !IS_ENABLED case here? After
all, we can be pretty certain that the write to the CPU reset vector is
immediately going to trap...
I suppose that perhaps without SMP, cpuidle, suspend, ... we could keep
running, but that seems a little niche.
next prev parent reply other threads:[~2013-06-13 19:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 9:12 [PATCH v2 0/3] ARM: tegra: add basic support for Trusted Foundations Alexandre Courbot
2013-06-13 9:12 ` [PATCH v2 1/3] ARM: tegra: " Alexandre Courbot
2013-06-13 14:35 ` Dave Martin
2013-06-14 8:43 ` Alexandre Courbot
2013-06-14 15:28 ` Stephen Warren
2013-06-13 19:19 ` Stephen Warren [this message]
2013-06-14 8:27 ` Alexandre Courbot
2013-06-14 15:25 ` Stephen Warren
2013-06-19 11:11 ` Dave Martin
2013-06-13 9:12 ` [PATCH v2 2/3] ARM: tegra: split setting of CPU reset handler Alexandre Courbot
2013-06-13 19:21 ` Stephen Warren
2013-06-14 8:45 ` Alexandre Courbot
2013-06-13 9:12 ` [PATCH v2 3/3] ARM: tegra: set CPU reset handler with firmware op Alexandre Courbot
2013-06-13 19:23 ` Stephen Warren
2013-06-14 8:54 ` Alexandre Courbot
2013-06-14 15:30 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BA1B41.6030002@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox