From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 3/3] ARM: keystone: Enable SMP support on Keystone machines
Date: Thu, 13 Jun 2013 17:15:24 -0400 [thread overview]
Message-ID: <51BA366C.2090508@ti.com> (raw)
In-Reply-To: <20130613154949.GD27414@e106331-lin.cambridge.arm.com>
Marc,
On Thursday 13 June 2013 11:49 AM, Mark Rutland wrote:
> On Wed, Jun 12, 2013 at 10:25:17PM +0100, Santosh Shilimkar wrote:
>> Add basic SMP support for Keystone machines. This does not
>> include support for CPU hotplug for now.
>>
>> Cc: Olof Johansson <olof@lixom•net>
>> Cc: Arnd Bergmann <arnd@arndb•de>
>> Cc: arm at kernel.org
>>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
>> ---
[..]
>> +static int __cpuinit keystone_smp_boot_secondary(unsigned int cpu,
>> + struct task_struct *idle)
>> +{
>> + unsigned long start = virt_to_phys(&secondary_startup);
>> + int error;
>> +
>> + pr_debug("keystone-smp: booting cpu %d, vector %08lx\n",
>> + cpu, start);
>> +
>> + asm volatile (
>> + "mov r0, #0\n" /* power on cmd */
>> + "mov r1, %1\n" /* cpu */
>> + "mov r2, %2\n" /* start */
>> + ".inst 0xe1600070\n" /* smc #0 */
>
> In arch/arm/asm/opcodes-sec.h we have an __SMC() macro you could use here
> that'll use the correct opcode for arm or thumb kernels.
>
Thanks for the suggestion though I am going to leave above as is now.
I need to move this code to asm file when I add remainder of the
monitor API support. Also inserting the macro in between means,
I need to break down the asm into two blocks which I want to
avoid for now.
Regards,
Santosh
next prev parent reply other threads:[~2013-06-13 21:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 21:25 [PATCH v2 0/3] ARM: Add minimal support for TI Keystone SOCs Santosh Shilimkar
2013-06-12 21:25 ` [PATCH v2 1/3] ARM: dts: keystone: Add minimal Keystone SOC device tree data Santosh Shilimkar
2013-06-17 21:12 ` Olof Johansson
2013-06-17 22:20 ` Santosh Shilimkar
2013-06-12 21:25 ` [PATCH v2 2/3] ARM: keystone: Add minimal TI Keystone platform support Santosh Shilimkar
2013-06-17 21:19 ` Olof Johansson
2013-06-17 22:37 ` Santosh Shilimkar
2013-06-12 21:25 ` [PATCH v2 3/3] ARM: keystone: Enable SMP support on Keystone machines Santosh Shilimkar
2013-06-13 15:49 ` Mark Rutland
2013-06-13 21:15 ` Santosh Shilimkar [this message]
2013-06-17 21:21 ` Olof Johansson
2013-06-17 22:22 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BA366C.2090508@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox