From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] gpio: samsung: add PINCTRL_S3C24XX to exclude options
Date: Tue, 18 Jun 2013 00:43:41 +0900 [thread overview]
Message-ID: <51BF2EAD.9030504@samsung.com> (raw)
In-Reply-To: <1825186.C6XXUYx8Nl@amdc1227>
On 06/17/13 22:19, Tomasz Figa wrote:
> Hi Heiko,
>
> On Friday 14 of June 2013 00:45:27 Heiko St?bner wrote:
>> When a pinctrl driver is loaded legacy gpio support has to be disabled.
>> The code checking for the pinctrl presence is contained in an #ifdef
>> checking for the presence of a valid samsung pinctrl driver.
>>
>> There the new PINCTRL_S3C24XX was missing resulting in the check never
>> being run and the gpio being enabled breaking the pinctrl driver.
>>
>> Fix this by adding the missing CONFIG_PINCTRL_S3C24XX
>>
>> Signed-off-by: Heiko Stuebner<heiko@sntech•de>
>> ---
>> drivers/gpio/gpio-samsung.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
>> index a1392f4..c84503e 100644
>> --- a/drivers/gpio/gpio-samsung.c
>> +++ b/drivers/gpio/gpio-samsung.c
>> @@ -2949,7 +2949,8 @@ static __init int samsung_gpiolib_init(void)
>> int i, nr_chips;
>> int group = 0;
>>
>> -#if defined(CONFIG_PINCTRL_EXYNOS) || defined(CONFIG_PINCTRL_EXYNOS5440)
>> +#if defined(CONFIG_PINCTRL_EXYNOS) || defined(CONFIG_PINCTRL_EXYNOS5440) ||
>> \ + defined(CONFIG_PINCTRL_S3C24XX)
>
> I wonder if this wouldn't be simply covered by PINCTRL_SAMSUNG (except
> PINCTRL_EXYNOS5440 which doesn't use the common part).
>
Well, not added compatible for 's3c64xx-pinctrl' yet?
- Kukjin
next prev parent reply other threads:[~2013-06-17 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 22:44 [PATCH 0/3] ARM: S3C24XX: s3c2416 build fixes Heiko Stübner
2013-06-13 22:45 ` [PATCH 1/3] gpio: samsung: add PINCTRL_S3C24XX to exclude options Heiko Stübner
2013-06-17 13:13 ` Kukjin Kim
2013-06-17 16:49 ` Linus Walleij
2013-06-17 13:19 ` Tomasz Figa
2013-06-17 15:43 ` Kukjin Kim [this message]
2013-06-17 15:48 ` Tomasz Figa
2013-06-13 22:45 ` [PATCH 2/3] pinctrl: s3c24xx: use correct header for chained_irq functions Heiko Stübner
2013-06-17 13:16 ` Kukjin Kim
2013-06-17 15:45 ` Linus Walleij
2013-06-17 15:58 ` Kukjin Kim
2013-06-13 22:46 ` [PATCH 3/3] ARM: S3C24XX: update uart addresses in s3c2416-dt auxdata Heiko Stübner
2013-06-18 17:39 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BF2EAD.9030504@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox