public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: nsekhar@ti•com (Sekhar Nori)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v11 3/8] ARM: edma: Add EDMA crossbar event mux support
Date: Thu, 20 Jun 2013 10:19:32 +0530	[thread overview]
Message-ID: <51C289DC.1080604@ti.com> (raw)
In-Reply-To: <CAD=GYpbVUu4H8vkLHYAGPUMqdzmbJncX4yOR+5k+5B8NJhfgAQ@mail.gmail.com>



On 6/20/2013 6:06 AM, Joel A Fernandes wrote:

>>> +             /* Clear the xbar mapped channels in unused list */
>>> +             xbar_chans = info[j]->xbar_chans;
>>> +             if (xbar_chans) {
>>> +                     for (i = 0; xbar_chans[i][1] != -1; i++) {
>>> +                             off = xbar_chans[i][1];
>>> +                             clear_bits(off, 1,
>>> +                                     edma_cc[j]->edma_unused);
>>
>> Please fix the alignment here.
> 
> I noticed the alignment was off in a few other places in that driver.
> Fixed those up too.

If you do, please make it a separate (pre)patch.

Thanks,
Sekhar

  reply	other threads:[~2013-06-20  4:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18  6:38 [PATCH v11 0/8] ] DMA Engine support for AM33XX Joel A Fernandes
2013-06-18  6:38 ` [PATCH v11 1/8] dmaengine: edma: Add TI EDMA device tree binding Joel A Fernandes
2013-06-18  6:38 ` [PATCH v11 2/8] ARM: edma: Add DT and runtime PM support to the private EDMA API Joel A Fernandes
2013-06-18  9:39   ` Sekhar Nori
2013-06-18  6:38 ` [PATCH v11 3/8] ARM: edma: Add EDMA crossbar event mux support Joel A Fernandes
2013-06-18 10:19   ` Sekhar Nori
2013-06-20  0:36     ` Joel A Fernandes
2013-06-20  4:49       ` Sekhar Nori [this message]
2013-06-18  6:38 ` [PATCH v11 4/8] ARM: dts: add AM33XX EDMA support Joel A Fernandes
2013-06-18  6:38 ` [PATCH v11 5/8] ARM: dts: add AM33XX SPI DMA support Joel A Fernandes
2013-06-18  6:38 ` [PATCH v11 6/8] dmaengine: edma: enable build for AM33XX Joel A Fernandes
2013-06-18  6:38 ` [PATCH v11 7/8] spi: omap2-mcspi: add generic DMA request support to the DT binding Joel A Fernandes
2013-06-18  6:38 ` [PATCH v11 8/8] spi: omap2-mcspi: convert to dma_request_slave_channel_compat() Joel A Fernandes
2013-06-18 13:07 ` [PATCH v11 0/8] ] DMA Engine support for AM33XX Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C289DC.1080604@ti.com \
    --to=nsekhar@ti$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox