From: gang.chen@asianux•com (Chen Gang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] arch: arm64: kernel: add '#ifdef CONFIG_COMPAT' for aarch32_break_handler()
Date: Mon, 24 Jun 2013 18:16:08 +0800 [thread overview]
Message-ID: <51C81C68.5080101@asianux.com> (raw)
In-Reply-To: <20130624101429.GF23779@mudshark.cambridge.arm.com>
On 06/24/2013 06:14 PM, Will Deacon wrote:
> On Mon, Jun 24, 2013 at 10:27:49AM +0100, Chen Gang wrote:
>> >
>> > If 'COMPAT' not defined, aarch32_break_handler() cannot pass compiling,
>> > and it can work independent with 'COMPAT', so remove dummy definition.
>> >
>> > The related make:
>> >
>> > make ARCH=arm64 randconfig
>> > make ARCH=arm64 menuconfig
>> > make ARCH=arm64 V=1 EXTRA_CFLAGS=-W
> This sequence isn't really very useful, so I wouldn't bother including it in
> the commit message. You can trigger this issue just by disabling
> CONFIG_COMPAT.
>
OK, thanks. Next time, I need notice about it.
>> > The related error:
>> >
>> > arch/arm64/kernel/debug-monitors.c:249:5: error: redefinition of ?aarch32_break_handler?
>> > In file included from arch/arm64/kernel/debug-monitors.c:29:0:
>> > /root/linux-next/arch/arm64/include/asm/debug-monitors.h:89:12: note: previous definition of ?aarch32_break_handler? was here
>> >
>> >
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux•com>
>> > ---
>> > arch/arm64/include/asm/debug-monitors.h | 7 -------
>> > 1 files changed, 0 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/arch/arm64/include/asm/debug-monitors.h b/arch/arm64/include/asm/debug-monitors.h
>> > index ef8235c..a2232d0 100644
>> > --- a/arch/arm64/include/asm/debug-monitors.h
>> > +++ b/arch/arm64/include/asm/debug-monitors.h
>> > @@ -83,14 +83,7 @@ static inline int reinstall_suspended_bps(struct pt_regs *regs)
>> > }
>> > #endif
>> >
>> > -#ifdef CONFIG_COMPAT
>> > int aarch32_break_handler(struct pt_regs *regs);
>> > -#else
>> > -static int aarch32_break_handler(struct pt_regs *regs)
>> > -{
>> > - return -EFAULT;
>> > -}
>> > -#endif
> Code looks fine to me:
>
> Acked-by: Will Deacon <will.deacon@arm•com>
Thanks.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-06-24 10:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-22 5:54 [PATCH] arch: arm64: kernel: add '#ifdef CONFIG_COMPAT' for aarch32_break_handler() Chen Gang
2013-06-24 8:47 ` Will Deacon
2013-06-24 9:19 ` Chen Gang
2013-06-24 9:27 ` [PATCH v2] " Chen Gang
2013-06-24 10:14 ` Will Deacon
2013-06-24 10:16 ` Chen Gang [this message]
[not found] ` <51C81A39.5060909@asianux.com>
2013-06-24 15:43 ` [Suggestion] arch: arm64: xen: "ln -s" the paravirt.h from arm Stefano Stabellini
2013-06-24 16:50 ` Stefano Stabellini
2013-06-25 1:31 ` Chen Gang
2013-06-25 12:32 ` Stefano Stabellini
2013-06-25 13:25 ` Catalin Marinas
2013-06-25 15:54 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C81C68.5080101@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox