From: dirk.behme@de•bosch.com (Dirk Behme)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs
Date: Wed, 26 Jun 2013 14:28:58 +0200 [thread overview]
Message-ID: <51CADE8A.7010008@de.bosch.com> (raw)
In-Reply-To: <AD13664F485EE54694E29A7F9D5BE1AF84939C@039-SN2MPN1-022.039d.mgd.msft.net>
On 17.06.2013 10:11, Liu Hui-R64343 wrote:
>> -----Original Message-----
>> From: Shawn Guo [mailto:shawn.guo at linaro.org]
>> Sent: Monday, June 17, 2013 3:31 PM
>> To: Liu Hui-R64343
>> Cc: linux-arm-kernel at lists.infradead.org
>> Subject: Re: [PATCH] ARM: smp_twd: twd_update_frequency need be run on
>> all online CPUs
>>
>> On Thu, Jun 13, 2013 at 07:19:40AM +0800, Jason Liu wrote:
>>> When the local timer freq changed, the twd_update_frequency function
>>> should be run all the CPUs include itself, otherwise, the twd freq
>>> will not get updated and the local timer will not run correcttly.
>>>
>>> smp_call_function will run functions on all other CPUs, but not
>>> include himself, this is not correct,use on_each_cpu instead to fix
>> this issue.
>>>
>>> Signed-off-by: Jason Liu <r64343@freescale•com>
>>> Cc: Russell King <linux@arm•linux.org.uk>
>>> Cc: Linus Walleij <linus.walleij@linaro•org>
>>> Cc: Rob Herring <rob.herring@calxeda•com>
>>> Cc: Shawn Guo <shawn.guo@linaro•org>
>>
>> Acked-by: Shawn Guo <shawn.guo@linaro•org>
>
> Thanks Shawn.
>
>>
>> BTW, is there anything wrong with your mailer (git send-email command
>> line)? I do not see people you put on Cc tag here show up in Cc of the
>> email. And that might the be reason why people are not responding so
>> far.
>
> Yes, there is one issue in my script and get fixed. I will put the patch
> Into Russell's patch tracking system after Mike and Russell reviewed it
> And also Cc stable kernel as Linus W. said.
Any news on this?
Thanks
Dirk
>> Shawn
>>
>>> Cc: Arnd Bergmann <arnd@arndb•de>
>>> Cc: stable at vger.kernel.org
>>> ---
>>> arch/arm/kernel/smp_twd.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
>>> index 90525d9..f6fd1d4 100644
>>> --- a/arch/arm/kernel/smp_twd.c
>>> +++ b/arch/arm/kernel/smp_twd.c
>>> @@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block
>> *nb,
>>> * changing cpu.
>>> */
>>> if (flags == POST_RATE_CHANGE)
>>> - smp_call_function(twd_update_frequency,
>>> + on_each_cpu(twd_update_frequency,
>>> (void *)&cnd->new_rate, 1);
>>>
>>> return NOTIFY_OK;
>>> --
>>> 1.7.10.4
next prev parent reply other threads:[~2013-06-26 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 23:19 [PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs Jason Liu
2013-06-13 8:00 ` Linus Walleij
2013-06-14 10:02 ` Liu Hui-R64343
2013-06-17 7:31 ` Shawn Guo
2013-06-17 8:11 ` Liu Hui-R64343
2013-06-26 12:28 ` Dirk Behme [this message]
2013-07-01 10:37 ` Liu Hui-R64343
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CADE8A.7010008@de.bosch.com \
--to=dirk.behme@de$(echo .)bosch.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox