From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 2/3] ARM: shmobile: BOCK-W: add VIN and ML86V7667 support
Date: Thu, 27 Jun 2013 15:45:54 +0400 [thread overview]
Message-ID: <51CC25F2.9020605@cogentembedded.com> (raw)
In-Reply-To: <8761x02khf.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 27-06-2013 9:25, Kuninori Morimoto wrote:
>> @@ -166,6 +187,16 @@ static const struct pinctrl_map bockw_pi
>> "usb0", "usb0"),
>> PIN_MAP_MUX_GROUP_DEFAULT("ehci-platform", "pfc-r8a7778",
>> "usb1", "usb1"),
>> + /* VIN0 */
>> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7778-vin.0", "pfc-r8a7778",
>> + "vin0_clk", "vin0"),
>> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7778-vin.0", "pfc-r8a7778",
>> + "vin0_data8", "vin0"),
>> + /* VIN1 */
>> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7778-vin.1", "pfc-r8a7778",
>> + "vin1_clk", "vin1"),
>> + PIN_MAP_MUX_GROUP_DEFAULT("r8a7778-vin.1", "pfc-r8a7778",
>> + "vin1_data8", "vin1"),
>> };
> Here, it includes VIN1 pin, but
>> #define FPGA 0x18200000
>> @@ -184,6 +215,16 @@ static void __init bockw_init(void)
>> r8a7778_add_hspi_device(0);
>> r8a7778_add_mmc_device(&sh_mmcif_plat);
>> r8a7778_add_usb_phy_device(&usb_phy_platform_data);
>> + r8a7778_add_vin_device(0, &vin_platform_data);
>> + /* VIN1 has a pin conflict with Ether */
>> + if (!IS_ENABLED(CONFIG_SH_ETH))
>> + r8a7778_add_vin_device(1, &vin_platform_data);
> what happen if SH_ETH was enabled here ?
> r8a7778_add_vin_device(1, xxx) is not called,
> but bockw_pinctrl_map was called with VIN1 setting ?
Don't worry, it's all tested. If the VIN1 platform device is not
registered, VIN1 pinmux settings won't be selected by the driver core.
> Best regards
> ---
> Kuninori Morimoto
WBR, Sergei
next prev parent reply other threads:[~2013-06-27 11:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 23:26 [PATCH v5 0/3] R8A7778/BOCK-W R-Car VIN driver support Sergei Shtylyov
2013-06-21 23:28 ` [PATCH v5 1/3] ARM: shmobile: r8a7778: add VIN support Sergei Shtylyov
2013-06-27 5:19 ` Kuninori Morimoto
2013-06-27 5:30 ` Simon Horman
2013-06-27 5:39 ` Kuninori Morimoto
2013-06-27 11:49 ` Sergei Shtylyov
2013-06-21 23:30 ` [PATCH v5 2/3] ARM: shmobile: BOCK-W: add VIN and ML86V7667 support Sergei Shtylyov
2013-06-27 5:25 ` Kuninori Morimoto
2013-06-27 11:45 ` Sergei Shtylyov [this message]
2013-06-21 23:31 ` [PATCH v5 3/3] ARM: shmobile: BOCK-W: enable VIN and ML86V7667 in defconfig Sergei Shtylyov
2013-06-27 4:48 ` [PATCH v5 0/3] R8A7778/BOCK-W R-Car VIN driver support Simon Horman
2013-06-27 11:21 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC25F2.9020605@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox