From: s.nawrocki@samsung•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs
Date: Fri, 28 Jun 2013 12:11:31 +0200 [thread overview]
Message-ID: <51CD6153.5050406@samsung.com> (raw)
In-Reply-To: <51CD4698.3070409@gmail.com>
On 06/28/2013 10:17 AM, Hui Wang wrote:
> On 06/26/2013 11:02 PM, Sylwester Nawrocki wrote:
>> Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2
>> receiver and MIPI DSI transmitter DPHYs.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung•com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung•com>
>> ---
>> Changes since v2:
>> - adapted to the generic PHY API v9: use phy_set/get_drvdata(),
>> - fixed of_xlate callback to return ERR_PTR() instead of NULL,
>> - namespace cleanup, put "GPL v2" as MODULE_LICENSE, removed pr_debug,
>> - removed phy id check in __set_phy_state().
>> ---
> [...]
>> +
>> + if (IS_EXYNOS_MIPI_DSIM_PHY_ID(id))
>> + reset = EXYNOS_MIPI_PHY_MRESETN;
>> + else
>> + reset = EXYNOS_MIPI_PHY_SRESETN;
>> +
>> + spin_lock_irqsave(&state->slock, flags);
>
> Sorry for one stupid question here, why do you use spin_lock_irqsave()
> rather than spin_lock(),
> I don't see the irq handler will use this spinlock anywhere in this c file.
Yes, there is no chance the PHY users could call the phy ops from within
an interrupt context. Especially now when there is a per phy object
mutex used in the PHY operation helpers. So I'll replace it with plain
spin_lock/unlock. Thank you for the review.
Regards,
Sylwester
next prev parent reply other threads:[~2013-06-28 10:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 15:02 [PATCH v3 0/5] Generic PHY driver for the Exynos SoC MIPI CSI-2/DSI DPHYs Sylwester Nawrocki
2013-06-26 15:02 ` [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs Sylwester Nawrocki
2013-06-27 7:52 ` Felipe Balbi
2013-06-27 8:37 ` Sylwester Nawrocki
2013-06-27 8:40 ` Felipe Balbi
2013-06-28 8:17 ` Hui Wang
2013-06-28 10:11 ` Sylwester Nawrocki [this message]
2013-06-29 8:57 ` Kishon Vijay Abraham I
2013-06-29 19:34 ` Sylwester Nawrocki
2013-07-01 5:24 ` Kishon Vijay Abraham I
2013-06-26 15:02 ` [PATCH v3 2/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi Sylwester Nawrocki
2013-06-27 7:52 ` Felipe Balbi
2013-06-26 15:02 ` [PATCH v3 3/5] video: exynos_mipi_dsim: Use the generic PHY driver Sylwester Nawrocki
2013-06-28 6:18 ` Donghwa Lee
2013-06-26 15:02 ` [PATCH v3 4/5] exynos4-is: Use the generic MIPI CSIS " Sylwester Nawrocki
2013-06-26 15:02 ` [PATCH v3 5/5] ARM: Samsung: Remove the MIPI PHY setup code Sylwester Nawrocki
2013-06-27 9:34 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CD6153.5050406@samsung.com \
--to=s.nawrocki@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox