From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RFC v2 04/14] ARM: debug: provide 8250 debug uart register shift configuration option
Date: Tue, 16 Jul 2013 14:38:48 -0400 [thread overview]
Message-ID: <51E59338.6020102@ti.com> (raw)
In-Reply-To: <E1Uz8FU-00047a-AB@rmk-PC.arm.linux.org.uk>
On Tuesday 16 July 2013 12:37 PM, Russell King wrote:
> Move the definition of the UART register shift out of the platform
> specific header file into the Kconfig files.
>
> Signed-off-by: Russell King <rmk+kernel@arm•linux.org.uk>
> ---
[..]
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 07ff149..5b44881 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -275,6 +275,7 @@ choice
[..]
> @@ -857,8 +872,17 @@ config DEBUG_LL_INCLUDE
> default "mach/debug-macro.S"
>
> config DEBUG_UART_8250
> - def_bool ARCH_EBSA110 || (FOOTBRIDGE && !DEBUG_DC21285_PORT) || \
> - ARCH_GEMINI || ARCH_RPC
> + def_bool ARCH_DOVE || ARCH_EBSA110 || \
> + (FOOTBRIDGE && !DEBUG_DC21285_PORT) || \
> + ARCH_GEMINI || ARCH_IOP13XX || ARCH_IOP32X || \
> + ARCH_IOP33X || ARCH_IXP4XX || ARCH_KIRKWOOD || \
> + ARCH_LPC32XX || ARCH_MV78XX0 || ARCH_ORION5X || ARCH_RPC
> +
> +config DEBUG_UART_8250_SHIFT
> + int "Register offset shift for the 8250 debug UART"
> + depends on DEBUG_UART_8250
> + default 0 if FOOTBRIDGE || ARCH_IOP32X
> + default 2
>
Just a question. Exposing selection choice for UART port
and probably flow control is just fine, but do we need to
really need config entries for SHIFT, PA, VA etc ?
Regards,
Santosh
next prev parent reply other threads:[~2013-07-16 18:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 16:32 [PATCH RFC v2 0/14] Clean up debugging support Russell King - ARM Linux
2013-07-16 16:34 ` [PATCH RFC v2 01/14] ARM: debug: fix wording error in DEBUG_LL_UART_NONE option help Russell King
2013-07-16 16:35 ` [PATCH RFC v2 02/14] ARM: debug: clean up low level kernel debugging selection Russell King
2013-07-16 16:36 ` [PATCH RFC v2 03/14] ARM: debug: provide 8250 debug uart flow control configuration option Russell King
2013-07-16 16:37 ` [PATCH RFC v2 04/14] ARM: debug: provide 8250 debug uart register shift " Russell King
2013-07-16 18:38 ` Santosh Shilimkar [this message]
2013-07-16 19:16 ` Russell King - ARM Linux
2013-07-16 19:24 ` Russell King - ARM Linux
2013-07-16 20:09 ` Santosh Shilimkar
2013-07-16 16:38 ` [PATCH RFC v2 05/14] ARM: debug: provide 8250 debug uart phys/virt address configuration options Russell King
2013-07-16 16:39 ` [PATCH RFC v2 06/14] ARM: debug: move 8250 debug include into arch/arm/include/debug/ Russell King
2013-07-16 16:40 ` [PATCH RFC v2 07/14] ARM: debug: add support for word accesses to debug/8250.S Russell King
2013-07-16 16:41 ` [PATCH RFC v2 08/14] ARM: debug: provide PL01x debug uart phys/virt address configuration options Russell King
2013-07-17 9:26 ` Pawel Moll
2013-07-16 16:42 ` [PATCH RFC v2 09/14] ARM: debug: move PL01X debug include into arch/arm/include/debug/ Russell King
2013-07-16 16:43 ` [PATCH RFC v2 10/14] ARM: debug: provide generic option choices for 8250 and PL01x ports Russell King
2013-07-16 16:44 ` [PATCH RFC v2 11/14] ARM: debug: remove DEBUG_ROCKCHIP_UART Russell King
2013-07-16 16:45 ` [PATCH RFC v2 12/14] ARM: debug: move keystone debug to generic 8250 code Russell King
2013-07-16 18:35 ` Santosh Shilimkar
2013-07-16 16:46 ` [PATCH RFC v2 13/14] ARM: debug: move davinci " Russell King
2013-07-17 12:05 ` Sekhar Nori
2013-07-17 17:02 ` Russell King - ARM Linux
2013-07-18 14:08 ` Sekhar Nori
2013-07-16 16:47 ` [PATCH RFC v2 14/14] ARM: debug: move Spear debug to generic PL01x code Russell King
2013-07-17 5:18 ` Viresh Kumar
2013-07-16 23:36 ` [PATCH RFC v2 0/14] Clean up debugging support H Hartley Sweeten
2013-07-17 17:04 ` Russell King - ARM Linux
2013-07-17 17:51 ` H Hartley Sweeten
2013-07-20 16:43 ` Andrew Lunn
2013-07-22 11:06 ` Russell King - ARM Linux
2013-07-22 15:53 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E59338.6020102@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox