From: gerlando.falauto@keymile•com (Gerlando Falauto)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: Kirkwood: Fix the internal register ranges translation
Date: Wed, 17 Jul 2013 08:35:38 +0200 [thread overview]
Message-ID: <51E63B3A.2010807@keymile.com> (raw)
In-Reply-To: <20130716125531.GD2317@localhost>
Hi Ezequiel,
On 07/16/2013 02:56 PM, Ezequiel Garcia wrote:
[...]
> Also, speaking of "device bus" this nand node should be behind a devicebus node.
>
> ranges = <MBUS_ID(0xf0, 0x01) 0 0 0xf1000000 0x100000 /* internal-regs */
> MBUS_ID(0x01, 0x2f) 0 0 0xf4000000 0x400>;
>
> devbus {
> status = "okay";
> ranges = <0 MBUS_ID(0x01, 0x2f) 0 0x400>;
>
> /* nand */
> nand {
> compatible = "marvell,orion-nand";
> reg = <0 0x400>;
> };
> };
>
> (notice this will allow you to relocate the base address of the NAND windows
> easily if it conflicts with your PCIe needs).
I am MAYBE slowly starting to understand this whole mbus rework.
Just one remark though: don't you think it would make sense to add
something like:
#define MBUS_ID_INTERNAL_REGS MBUS_ID(0xf0, 0x01)
#define MBUS_ID_NAND MBUS_ID(0x01, 0x2f)
I personally have a hard time reading numeric values for
GPIO_ACTIVE_LOW/GPIO_ACTIVE_HIGH.
Thanks,
Gerlando
>
>> avoid a later incosistency between the "unit-address" and the first
>> "reg" address:
>>
>>> #address-cells = <1>;
>>> #size-cells = <1>;
>>> @@ -171,7 +172,7 @@
>> > nand at 3000000 {
>> ^^^^^^^
>
> Oh, this should be fixed. I just missed it, and nobody noticed either.
>
next prev parent reply other threads:[~2013-07-17 6:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 15:31 [PATCH] ARM: Kirkwood: Fix the internal register ranges translation Ezequiel Garcia
2013-06-18 19:42 ` Sebastian Hesselbarth
2013-06-18 19:47 ` Ezequiel Garcia
2013-06-19 18:36 ` Jason Cooper
2013-06-19 18:42 ` Ezequiel Garcia
2013-06-19 18:43 ` Jason Cooper
2013-06-21 15:41 ` Jason Cooper
2013-07-16 9:37 ` Gerlando Falauto
2013-07-16 12:56 ` Ezequiel Garcia
2013-07-16 18:51 ` Gerlando Falauto
2013-07-18 14:05 ` Ezequiel Garcia
2013-07-17 6:35 ` Gerlando Falauto [this message]
2013-07-18 13:55 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E63B3A.2010807@keymile.com \
--to=gerlando.falauto@keymile$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox