From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ARM: shmobile: use common platform header for HPB-DMAC
Date: Fri, 19 Jul 2013 15:32:38 +0400 [thread overview]
Message-ID: <51E923D6.5050502@cogentembedded.com> (raw)
In-Reply-To: <51E92053.5080103@cogentembedded.com>
Hello.
On 19-07-2013 15:17, Sergei Shtylyov wrote:
>>>>> From: Max Filippov <max.filippov@cogentembedded•com>
>>>>> Use previously empty <mach/dma.h> to declare HPB-DMA slave IDs.
>>>>> Signed-off-by: Max Filippov <max.filippov@cogentembedded•com>
>>>>> [Sergei: changed the guard macro name, fixed comment, extended copyright.]
>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
>>>>> ---
>>>>> arch/arm/mach-shmobile/include/mach/dma.h | 25
>>>>> ++++++++++++++++++++++++-
>>>>> 1 file changed, 24 insertions(+), 1 deletion(-)
>>>> Thanks for your patch. Can you please explain the reason why you put
>>>> this shared information under mach/?
IIUC, because the only 2 file using it were under arch/arm/mach-shmobile/.
>>> I'm afraid that's more a question to the original author, Phil Edworthy.
>>> He put this stuff into <mach/hpb-dmae.h>.
>> Then, why you could send this patch instead of original author,
> Ask Phil why didn't he upstream his stuff. We, unlike him, do have
> obligation to upstream it.
>> even though you can't answer any question about it ?
> I'm not the author of the patch, let me remind you, Max Filippov is.
> He was on vacations.
Phil's patches were only for R8A7778, IIRC (yet, the platfrom DMA code was
placed in a separate file, not r8a7778.c). Max decided to use the
<mach/hpb-dmae.h> header for sharing the DMA channel IDs between R8A777[89], I
agreed but suggested to use the empty <mach/dma.h> instead.
>> Best regards
>> ---
>> Kuninori Morimoto
WBR, Sergei
next prev parent reply other threads:[~2013-07-19 11:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 22:43 [PATCH 0/3] R8A7778/BOCK-W: HPB-DMAC support for SDHI0 Sergei Shtylyov
2013-06-29 22:45 ` [PATCH 1/3] ARM: shmobile: use common platform header for HPB-DMAC Sergei Shtylyov
2013-07-01 4:11 ` Kuninori Morimoto
2013-07-01 12:11 ` Sergei Shtylyov
2013-07-18 21:56 ` Sergei Shtylyov
2013-07-02 4:59 ` Magnus Damm
2013-07-18 22:02 ` Sergei Shtylyov
2013-07-19 0:16 ` Kuninori Morimoto
2013-07-19 11:17 ` Sergei Shtylyov
2013-07-19 11:32 ` Sergei Shtylyov [this message]
2013-06-29 22:48 ` [PATCH 2/3] ARM: shmobile: r8a7778: add HPB-DMAC support Sergei Shtylyov
2013-07-01 4:12 ` Kuninori Morimoto
2013-07-18 22:04 ` Sergei Shtylyov
2013-06-29 22:50 ` [PATCH 3/3] ARM: shmobile: BOCK-W: enable DMA for SDHI0 Sergei Shtylyov
2013-07-01 1:30 ` [PATCH 0/3] R8A7778/BOCK-W: HPB-DMAC support " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E923D6.5050502@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox