From: ldewangan@nvidia•com (Laxman Dewangan)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: dts: tegra114: dalmore: fix the irq trigger type of Palmas MFD device
Date: Tue, 23 Jul 2013 20:13:23 +0530 [thread overview]
Message-ID: <51EE968B.1050103@nvidia.com> (raw)
In-Reply-To: <1374574191-24396-1-git-send-email-josephl@nvidia.com>
On Tuesday 23 July 2013 03:39 PM, Joseph Lo wrote:
> The IRQ trigger type of Palmas MFD device (tps65913) is low-level
> sensitive. The wrong configuration would cause an interrupt storm
> when booting the system. Fixing it in DT with appropriate interrupt
> type.
>
> Cc: Laxman Dewangan <ldewangan@nvidia•com>
> Signed-off-by: Joseph Lo <josephl@nvidia•com>
> ---
> arch/arm/boot/dts/tegra114-dalmore.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> index 76529e4..70b9d0c 100644
> --- a/arch/arm/boot/dts/tegra114-dalmore.dts
> +++ b/arch/arm/boot/dts/tegra114-dalmore.dts
> @@ -840,7 +840,7 @@
> palmas: tps65913 {
> compatible = "ti,palmas";
> reg = <0x58>;
> - interrupts = <0 86 0x4>;
> + interrupts = <0 86 0x8>;
>
This fails as GIC does not support the interrupt flag of 8.
[ 13.007755] genirq: Setting trigger mode 8 for irq 118 failed
(gic_set_type+0x0/0xf0)
[ 13.009152] palmas 1-0058: Irq flag is 0x00000000
I did not get the interrupt storm and even interrupt is not working on tot.
Two ways to resolve this:
- Change the interrupt flag to 0 from 4. Or
- Remove the nvidia,invert-interrupt; for PMC node.
next prev parent reply other threads:[~2013-07-23 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 10:09 [PATCH] ARM: dts: tegra114: dalmore: fix the irq trigger type of Palmas MFD device Joseph Lo
2013-07-23 14:43 ` Laxman Dewangan [this message]
2013-07-23 18:15 ` Stephen Warren
2013-07-24 6:56 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EE968B.1050103@nvidia.com \
--to=ldewangan@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox