From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include
Date: Thu, 25 Jul 2013 16:59:25 -0400 [thread overview]
Message-ID: <51F191AD.9020108@ti.com> (raw)
In-Reply-To: <51F0F283.5080900@ti.com>
On Thursday 25 July 2013 05:40 AM, Sekhar Nori wrote:
> On Thursday 25 July 2013 05:58 AM, Santosh Shilimkar wrote:
>> This driver no longer uses definitions from mach/hardware.h.
>> On the other hand, including this header breaks this driver
>> on non-davinci platforms which don't have such a header.
>>
>> Fix it.
>>
>> Cc: Sekhar Nori <nsekhar@ti•com>
>> Cc: Wolfram Sang <wsa@the-dreams•de>
>>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
>
> Acked-by: Sekhar Nori <nsekhar@ti•com>
>
> One minor nit:
>
>> ---
>> drivers/i2c/busses/i2c-davinci.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
>> index fa55605..ddaa2a3 100644
>> --- a/drivers/i2c/busses/i2c-davinci.c
>> +++ b/drivers/i2c/busses/i2c-davinci.c
>> @@ -41,7 +41,6 @@
>> #include <linux/of_i2c.h>
>> #include <linux/of_device.h>
>>
>
> You can now remove this empty line too.
>
Yes. Updated patch below with your ack added.
Regards,
Santosh
>From d7ae1c488ebae19028f33abff76c4d684271a7fb Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti•com>
Date: Tue, 23 Jul 2013 15:40:46 -0400
Subject: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include
This driver no longer uses definitions from mach/hardware.h.
On the other hand, including this header breaks this driver
on non-davinci platforms which don't have such a header.
Fix it.
Cc: Wolfram Sang <wsa@the-dreams•de>
Acked-by: Sekhar Nori <nsekhar@ti•com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
---
drivers/i2c/busses/i2c-davinci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index fa55605..5898df3 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -40,8 +40,6 @@
#include <linux/gpio.h>
#include <linux/of_i2c.h>
#include <linux/of_device.h>
-
-#include <mach/hardware.h>
#include <linux/platform_data/i2c-davinci.h>
/* ----- global defines ----------------------------------------------- */
--
1.7.9.5
next prev parent reply other threads:[~2013-07-25 20:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 0:28 [PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs Santosh Shilimkar
2013-07-25 0:28 ` [PATCH 1/2] i2c: davinci: remove useless mach/hardware include Santosh Shilimkar
2013-07-25 9:40 ` Sekhar Nori
2013-07-25 20:59 ` Santosh Shilimkar [this message]
2013-08-15 12:31 ` Wolfram Sang
2013-07-25 0:28 ` [PATCH 2/2] i2c: davinci: Allow i2c driver available for keystone platforms Santosh Shilimkar
2013-08-15 12:31 ` Wolfram Sang
2013-08-09 20:09 ` [PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs Santosh Shilimkar
2013-08-11 9:53 ` Wolfram Sang
2013-08-12 0:26 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F191AD.9020108@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox